Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin meta option to control if it can be used as command #252

Open
kecso opened this issue Jan 27, 2021 · 3 comments
Open

Plugin meta option to control if it can be used as command #252

kecso opened this issue Jan 27, 2021 · 3 comments

Comments

@kecso
Copy link
Member

kecso commented Jan 27, 2021

A new option in the meta info of a plugin could control if the plugin was intended to use as contex based command.
That way the standard UI could make the initiation easier.
For this type of plugin, the static options dialog will not come up by default, as no command should take additional parameters that are not controlled by the context.

@kecso kecso added this to the v2.25.3 milestone Jan 27, 2021
@kecso kecso self-assigned this Jan 27, 2021
@brollb
Copy link
Collaborator

brollb commented Jan 27, 2021

Why won't the options dialog come up when running a plugin from the context menu? Is it safe to say that this information is specific to the composition/model editor? It would be nice if there was a better way to handle visualizer-specific configuration information rather than adding a bunch of (possibly colliding) registry values.

@kecso
Copy link
Member Author

kecso commented Jan 27, 2021

It is a plugin meta-data.
It will not be a registry value, and because we only responsible for the standard UI, that is where we offer solutions that can be specialized for domains using it. (although I believe it is not that hard to see how anyone can adopt this method - plus it is connected more to the plugin and the intended use of the plugin than the visualizer itself...)
We do have visualizer specific configurations, but as you know setting them up is cumbersome and usually if one has the resource to do a specific visualizer, they usually can handle context-menus themselves.
On the other hand, the ones stuck with plugins and standard UI will not be able to offer intuitive UI options...

Finally, the options can come up, I was just thinking that it would be counterintuitive if the user would need to make selections as well (but these can be controlled separately as currently).

@pmeijer pmeijer modified the milestones: v2.25.3, v2.26.0 Jan 12, 2023
@pmeijer pmeijer removed this from the v2.26.0 milestone Sep 1, 2023
@pmeijer
Copy link
Contributor

pmeijer commented Sep 1, 2023

Are you proposing adding an extra kvp to the plugin-metadata.json.
Something like:

   ....
   "skipManualConfigurationStep": false,

If false (default) no changes, and if true the plugin-manager in the generic UI (or any other UI could use it too) would skip the Plugin Configuration Dialog and just execute the plugin.
If so, I'd just make sure that it runs on the browser by default (if that is the default) and if only server execution is enabled for the plugin - then on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants