Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss the future of https://sonarwhal.com/docs/user-guide/rules/ #391

Closed
alrra opened this issue Feb 19, 2018 · 18 comments
Closed

Discuss the future of https://sonarwhal.com/docs/user-guide/rules/ #391

alrra opened this issue Feb 19, 2018 · 18 comments
Labels

Comments

@alrra
Copy link
Contributor

alrra commented Feb 19, 2018

Now that the rules are no longer included in sonarwhal, I think https://sonarwhal.com/docs/user-guide/rules/ should be automatically generated, instead of having it in packages/sonarwhal/docs/user-guide/rules/index.md (see also: webhintio/hint#822).

@molant
Copy link
Member

molant commented Feb 19, 2018

Was thinking the same. We probably need to rethink the layout of the page.

@qzhou1607-zz
Copy link
Contributor

Maybe we can use this https://hexo.io/api/generator.html#Archive-Page from Hexo. We will need to keep the category information somewhere, maybe in the frontmatter of each rule doc, or in _config.yml.

@molant
Copy link
Member

molant commented Feb 20, 2018

We can try to get the category from rule.ts

qzhou1607-zz added a commit to qzhou1607-zz/sonarwhal.com that referenced this issue Feb 21, 2018
qzhou1607-zz added a commit to qzhou1607-zz/sonarwhal.com that referenced this issue Feb 21, 2018
qzhou1607-zz added a commit to qzhou1607-zz/sonarwhal.com that referenced this issue Feb 21, 2018
@molant
Copy link
Member

molant commented Mar 2, 2018

Adding @ststimac to the conversation. This is something we need to address sooner rather than later.
We are going to have probably a new category development (or similar) with all the typescript, webpack, etc. rules and there are going to be in @TheLarkInn's words "hundreds of them" 🙄

@ststimac
Copy link
Member

ststimac commented Mar 2, 2018

Are you talking about updating the individual rule pages or the overview page with all the categories?

We should probably redo the side table of contents if there are going to be "hundreds" of new rules.

@ststimac
Copy link
Member

ststimac commented Mar 2, 2018

I've got an idea for the layout. I'll do a quick mockup for this on Monday.

@ststimac
Copy link
Member

ststimac commented Mar 5, 2018

Proposal for the rules landing page:

screen shot 2018-03-05 at 1 34 03 pm

Show first 5 rules under each category and then any one that has more than that can be expanded to show the rest for a category.

@molant
Copy link
Member

molant commented Mar 5, 2018

Can we have somewhere how many rules for each category we have?
For the navigation on the left, is it going to be blank, have a list with all the rules, list the categories?

I'm not convinced that not listing all the rules directly is the best idea. Maybe we could have a landing for categories and then a landing for each category?

In this page we will have the description of each category, how many rules we have for each one, and link to the category (don't think we need more space than the one you've allocated already), and in the category landing page something similar to what we have right now?

@molant
Copy link
Member

molant commented Mar 5, 2018

And I just saw #403 re the navigation on the left side

@ststimac
Copy link
Member

ststimac commented Mar 7, 2018

Two other options:
rules-lp-03052018-01

rules-lp-03052018-02

@molant
Copy link
Member

molant commented Mar 8, 2018

I like the titles of the first option (the one with the icon inline with the name of the category) mixed with the second option that has the count of rules and view all in the same line.

@ststimac
Copy link
Member

ststimac commented Mar 8, 2018

new mockup
screen shot 2018-03-08 at 3 28 20 pm

@molant
Copy link
Member

molant commented Mar 9, 2018

Ship it!

@ststimac
Copy link
Member

ststimac commented Mar 9, 2018

I still need to design a landing page for the individual categories.

Are there really going to be hundreds of rules under the new category? I'm trying to design with that in mind.

@molant
Copy link
Member

molant commented Mar 9, 2018

Maybe not hundreds, but there could be quite a few for a given category (a few tens).

@ststimac
Copy link
Member

ststimac commented Mar 9, 2018

screen shot 2018-03-09 at 2 28 33 pm

Well depending on how many rules we start accumulating, if the list gets long enough, it should probably overflow into a multi-column layout, but we're probably not there yet. I will set it up though so that if we reach so many lines of rules, it will overflow into the next column.

@molant
Copy link
Member

molant commented Mar 9, 2018

👍

@ststimac
Copy link
Member

So from a responsive standpoint, the two column layout works better. At smaller browser widths, the 3 column layout gets messy because the rule category titles are mostly pretty long, and end up being longer than the column and breaking onto a new line. It just doesn't flow well. I will be going with the following layout. Also the icons are missing because none of the images are loading when I run npm run steph

I will also make a note in the PR but the page title should be RULE Categories, not plural like we currently have: Rules Categories.

screen shot 2018-03-15 at 10 27 15 am

@molant molant closed this as completed in 6e967f6 Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants