Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 for the manifest icon #479

Closed
alrra opened this issue Aug 8, 2018 · 9 comments
Closed

404 for the manifest icon #479

alrra opened this issue Aug 8, 2018 · 9 comments
Assignees
Labels

Comments

@alrra
Copy link
Contributor

alrra commented Aug 8, 2018

https://webhint.io/static/images/manifest-icon.png => 404

Ref: webhintio/hint#1220

@ststimac
Copy link
Member

ststimac commented Aug 8, 2018

I don't think we ever created a manifest icon so one will need to be added.

@molant
Copy link
Member

molant commented Aug 8, 2018

IIRC we were using the apple touch icon for this. Maybe we are not updating the Manifest content when the file gets optimized and cache busted (which we used to do 😖).

@ststimac
Copy link
Member

ststimac commented Aug 8, 2018

so not a design issue?

@ststimac ststimac removed their assignment Aug 8, 2018
@molant molant closed this as completed in b5d29a9 Aug 8, 2018
@molant molant self-assigned this Aug 8, 2018
@molant
Copy link
Member

molant commented Aug 8, 2018

@ststimac nope. I just merged the fix and waiting for deployment.

molant added a commit that referenced this issue Aug 8, 2018
@alrra
Copy link
Contributor Author

alrra commented Aug 8, 2018

@molant The image issue is fixed, but now we have "/static/site.webmanifest".

@alrra alrra reopened this Aug 8, 2018
@molant molant closed this as completed in 9473c83 Aug 8, 2018
@molant
Copy link
Member

molant commented Aug 8, 2018

9473c83 fixes it

alrra pushed a commit that referenced this issue Aug 8, 2018
@Malvoz
Copy link
Member

Malvoz commented Oct 31, 2018

Now the image src is resolved as /static/static/images/manifest-icon-a3d1c16640.png

@Malvoz
Copy link
Member

Malvoz commented May 24, 2019

@molant

webhintio/hint#2496 (comment)

I believe we still have some issue with the manifest in webhint.io and one of the icons not existing anymore (or something like that).

Yeah the issue still persist. The problem is that the manifest file itself resides inside /static/ but links (relatively) to "src": "static/images/...", if src rather points to "/static/images/..." its should be good.

molant added a commit that referenced this issue May 25, 2019
Make the link absolute.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #479

Co-authored-by: Robert Linder <[email protected]>
@molant
Copy link
Member

molant commented May 25, 2019

Thanks @Malvoz, I fixed it via ec9b221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants