Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the master branch to be protected after we got one more commiters #10

Open
huan opened this issue Jun 4, 2020 · 2 comments
Open

Make the master branch to be protected after we got one more commiters #10

huan opened this issue Jun 4, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@huan
Copy link
Member

huan commented Jun 4, 2020

So that we can improve the code quality for our master branch.

To be done.
@huan huan added the enhancement New feature or request label Jun 4, 2020
@jcai
Copy link
Collaborator

jcai commented Jun 4, 2020

禁止force push?

@huan
Copy link
Member Author

huan commented Jun 4, 2020

Yes. after the branch has been protected, the force push will be forbidden.

And there are also other benefits:

  1. need to use Pull Request to merge code into the master branch
  2. The CI must turn green
  3. Requires code review & approval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcai @huan