Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor EventEmitter #18

Open
jcai opened this issue Jun 15, 2020 · 0 comments
Open

refactor EventEmitter #18

jcai opened this issue Jun 15, 2020 · 0 comments

Comments

@jcai
Copy link
Collaborator

jcai commented Jun 15, 2020

Now EventEmitter is a Object instance only used by Wechaty.Refactor EventEmitter as trait to support friendship or other class.
jcai added a commit that referenced this issue Jun 15, 2020
@jcai
✨ #18 Refactor EventEmitter
f8cc75b
jcai added a commit that referenced this issue Jun 15, 2020
@jcai
✨ #18 add some tests from room events
8f5fd23
jcai added a commit that referenced this issue Jun 15, 2020
@jcai
✨ #18 fix compile warning
ae5e515 
[INFO] Compiling 23 Scala sources to /Users/jcai/workspace/oss/scala-wechaty/wechaty-puppet/target/classes ...
[WARNING] /Users/jcai/workspace/oss/scala-wechaty/wechaty-puppet/src/main/scala/wechaty/puppet/ResourceBox.scala:9: imported `Puppet' is permanently hidden by definition of trait Puppet in package puppet
jcai added a commit that referenced this issue Jun 15, 2020
@jcai
✨ #18 fix test error
f72d16f 
[ERROR] Errors:
[ERROR]   MessageTest.testMention:50 » StatusRuntime UNIMPLEMENTED: Method not found: we...
[ERROR]   MessageTest.testMention2:90 » StatusRuntime UNIMPLEMENTED: Method not found: w...
[ERROR]   MessageTest.testMention3:131 » StatusRuntime UNIMPLEMENTED: Method not found: ...
[INFO]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcai