Don't run on_validation_epoch_end() during sanity checking if val-accuracy-interval is greater than max epochs. #859
Labels
API
This tag is used for small improvements to the readability and usability of the python API.
good first issue
Good for newcomers
In https://deepforest.readthedocs.io/en/v1.4.1/user_guide/09_configuration_file.html#val-accuracy-interval, we tell users that to turn off the validation callback, set the interval to greater than the number of epochs.
DeepForest/src/deepforest/main.py
Line 718 in e5f3301
But that's not quite true, because during sanity checking the self.current_epoch = 0, this means it still checks the line above, there is no reason and is probably dangerous, to check the validation dataloader if we don't intend on ever calling it during training.
More on sanity checking
https://lightning.ai/forums/t/validation-sanity-check/174
https://pytorch-lightning.readthedocs.io/en/0.9.0/api/pytorch_lightning.trainer.evaluation_loop.html
This issue should wait on the refactor of #858
The text was updated successfully, but these errors were encountered: