Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for portalr data path #88

Open
ha0ye opened this issue Feb 23, 2019 · 0 comments
Open

Add checks for portalr data path #88

ha0ye opened this issue Feb 23, 2019 · 0 comments
Labels
infrastructure how MATSS runs

Comments

@ha0ye
Copy link
Member

ha0ye commented Feb 23, 2019

MATSS uses a different environmental variable than portalr. (though they can be set to the same value, since both portalr and MATSS download individual datasets into named subfolders.

Ideally, we want to accommodate:

  • people who set different paths for portalr and MATSS
  • people who don't use portalr, but will be getting portal data using the MATSS functions

I think we should add a few checks:

  • when calling use_default_data_path() from MATSS, check if there is one set for portalr, and give the user instructions for setting it for portalr if it's missing or is different
  • add a check to any functions that download data in MATSS or portalr to give a warning that the default path is going to be used if the data path is not set when the download function is called.
@ha0ye ha0ye changed the title Add checks for **portalr** data path Add checks for portalr data path Feb 23, 2019
@ha0ye ha0ye added dataset adding new data to MATSS infrastructure how MATSS runs labels Mar 21, 2019
@ha0ye ha0ye mentioned this issue Apr 23, 2019
15 tasks
@ha0ye ha0ye removed the dataset adding new data to MATSS label Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure how MATSS runs
Projects
None yet
Development

No branches or pull requests

1 participant