If there is only one VM, the list of VMs remains stuck on "Loading…"

[andydavies]

This is the first time I've installed esxi-simple-web so I can't tell whether this is a general problem or just particular to me.

The host is running ESXi 5.5u2 main page appears OK but when I switch to the list of VMs it get's stuck on loading.

The AJAX call to /mob/?moid=ha-folder-vm returns the following response

Raw content of the response is https://gist.github.com/andydavies/1ed8a11158bae8656b61

[andydavies]

Issue only happens when the host has one VM - if there's more that one VM the list is fine

Issue appears to be data.childEntity.ManagedObjectReference when there's more that one VM it's an array of objects but when there's only one VM it's an object rather than an array with one object.

When there's only one VM the code below iterates over the object properties rather than over the objects in the array and so doesn't 'find' the VM.

https://github.com/weikinhuang/esxi-simple-web/blob/master/web/js/controllers.js#L99

    var newVms = {};
    angular.forEach(data.childEntity.ManagedObjectReference, function(vm) {
        var vmId = vm["#text"];

[andydavies]

Looks like transforming the data from XML to JSON doesn't account for single entry arrays
https://github.com/weikinhuang/esxi-simple-web/blob/master/web/js/services.js#L43

    xmlData = xmlData.replace(/xsi:/g, "").replace(/(type="[^"]+".+?)type="[^"]+"/g, "$1");

https://github.com/weikinhuang/esxi-simple-web/blob/master/web/js/services.js#L49

removes xsi:type="ArrayOfManagedObjectReference"

e.g. from

<childEntity xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="urn:vim25" versionId="5.5" xsi:type="ArrayOfManagedObjectReference">
    <ManagedObjectReference type="VirtualMachine" xsi:type="ManagedObjectReference">4</ManagedObjectReference>
</childEntity>

to

<childEntity xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="urn:vim25" versionId="5.5" >
    <ManagedObjectReference type="VirtualMachine" >4</ManagedObjectReference>
</childEntity>

But removing this line causes breakage elsewhere and doesn't fix the issue anyway!

[andydavies]

See #6 for a fix, might be a more elegant way of achieving same result.