Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that connection meta is updated correctly #203

Open
edsko opened this issue Jul 25, 2024 · 1 comment
Open

Test that connection meta is updated correctly #203

edsko opened this issue Jul 25, 2024 · 1 comment
Labels
enhancement New feature or request priority: medium Should be done before the library can be considered complete testsuite Problem with the test suite but not the main library

Comments

@edsko
Copy link
Collaborator

edsko commented Jul 25, 2024

On the client, whenever we make a new request, and process the response headers, we call updateConnectionMeta. One important function of this is to update our knowledge of the peer's supposed compression algorithms: only after the first response do we know what compression algorithms they support. We should have a test that verifies that after the first message, all future responses are compressed.

@edsko edsko added enhancement New feature or request testsuite Problem with the test suite but not the main library priority: low Minor enhancements labels Jul 25, 2024
@edsko edsko mentioned this issue Jul 25, 2024
@edsko edsko added priority: medium Should be done before the library can be considered complete and removed priority: low Minor enhancements labels Jul 25, 2024
@edsko
Copy link
Collaborator Author

edsko commented Jul 25, 2024

Since we actually had a regression here, increasing priority to medium. It's easy to miss in tests, since compression negotiation (including no compression) is completely transparent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium Should be done before the library can be considered complete testsuite Problem with the test suite but not the main library
Projects
None yet
Development

No branches or pull requests

1 participant