From 09db56ba9343c597340b2c7715f43ff9b10826f6 Mon Sep 17 00:00:00 2001 From: Domenic Denicola Date: Mon, 30 Sep 2024 13:18:31 +0900 Subject: [PATCH] Reorder promise resolutions for navigation API The API method tracker finished promise vs. the navigation transition finished promise ordering did not match the tests and Chromium implementation. There's no real argument for one order vs. the other, so update the spec to match. Closes #10646. --- source | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/source b/source index fd018b599ac..6d7b20c4cd5 100644 --- a/source +++ b/source @@ -95198,6 +95198,9 @@ interface NavigationDestination {
  • Fire an event named navigatesuccess at navigation.

  • +
  • If apiMethodTracker is non-null, then resolve the finished + promise for apiMethodTracker.

  • +
  • If navigation's transition is not null, then resolve navigation's transition's @@ -95206,9 +95209,6 @@ interface NavigationDestination {

  • Set navigation's transition to null.

  • - -
  • If apiMethodTracker is non-null, then resolve the finished - promise for apiMethodTracker.

  • and the following failure steps given reason rejectionReason:

    @@ -95238,6 +95238,9 @@ interface NavigationDestination { ErrorEvent, with additional attributes initialized according to errorInfo.

    +
  • If apiMethodTracker is non-null, then reject the finished + promise for apiMethodTracker with rejectionReason.

  • +
  • If navigation's transition is not null, then reject navigation's transition's @@ -95246,9 +95249,6 @@ interface NavigationDestination {

  • Set navigation's transition to null.

  • - -
  • If apiMethodTracker is non-null, then reject the finished - promise for apiMethodTracker with rejectionReason.