Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering has been broken? #85

Open
brambox opened this issue Sep 26, 2021 · 8 comments
Open

Rendering has been broken? #85

brambox opened this issue Sep 26, 2021 · 8 comments

Comments

@brambox
Copy link

brambox commented Sep 26, 2021

I used an old version of the emulator and it had superior crispness and colors.
Now it's blurry and over brighten full disaster. I see this new GL thing but even after turning it off and reload it only gets a bit better but it's still no way near to the old rendering. Can you please fix it to have a proper crispness and RGB colors?
Maybe there is a temporary fix I can set somewhere in the code to use the old rendering way.
Thank you!

@whscullin
Copy link
Owner

Non-NTSC shader rendering is largely unchanged, did you reload the page after changing the preference as mentioned in the *?

@brambox
Copy link
Author

brambox commented Sep 26, 2021

Yes. I will make pic. https://imgur.com/a/YVD1daO
top is the new

@whscullin
Copy link
Owner

Ah. Yeah, that predates the introduction of the GL renderer by a bit. Somebody pointed out that I was using the IIGS colors instead of NTSC correct colors, so I corrected that. The difficulty of trying to please everybody, I guess. 🤷‍♂️

@brambox
Copy link
Author

brambox commented Sep 27, 2021

It's not just the colors change. The main thing is it is blurry like some kind of filter applied.
Here on this pic it is easy to see on the Apple Text. https://imgur.com/L1rzpQL
Top again is new and if you enable GL it's even worse.
Is it possible to fix it?

@iflan
Copy link
Contributor

iflan commented Sep 27, 2021

Hi there,

GL mode is trying to actually simulate what you'd see if you were looking at an old-school CRT monitor, including barrel effects, the shadow mask, and so on. If you're looking for crisp graphics, then GL mode is not what you want.

In regular mode, there are still rendering artifacts due to how the Apple actually drew hi-res graphics. You can read about it a bit here:

https://en.wikipedia.org/wiki/Apple_II_graphics#High-Resolution_.28Hi-Res.29_graphics

There's a similar issue that was opened on AppleWin:

AppleWin/AppleWin#357

In the end, there's a tug of war between accurate rendering and "pretty" rendering. I don't know if there's any "best" solution except having several choices. But giving people all the choices also means maintaining all those choices as well.

Ian

@whscullin
Copy link
Owner

I've updated the non-GL canvas rendering to use an anti-smoothing flag I uncovered when doing some work on full page rendering. Chrome seems to respect it, Safari and Firefox do their own thing, of course, but they were doing something different before, too.

@brambox
Copy link
Author

brambox commented Sep 28, 2021

Thank you!
Will it be possible to get the rgb card rendering like with the gl option on but without the bluring?

@whscullin
Copy link
Owner

I'm not quite sure what you mean. The eventual goal behind keeping two renderers is to have one renderer that emulates NTSC and its artifacts, the other to emulate something like the Video 7/Apple Extended RGB card, with no artifact colors and sharp B&W modes.

I do plan on making the NTSC mode more tunable, the underlying library has very flexible control over the level of artifacting, it's just a little tricky fitting that many dials into the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants