-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'select all' when batch tagging #446
Comments
Hi, can I work on this feature? |
Thank you 🤝 I'm sometimes rather particular about the UI (user interface), so don't worry too much about making things look great / harmonious with the rest -- I can fix it up after your code merges in 👍 Please feel free to reach out with any questions -- I'm happy to help 🙌 |
Only suggestion for an addition here is: make the same button become "deselect all" once it has selected all, and maybe have the button have the format of "deselect all (<number_of_videos_selected>)" so we have a better understanding. |
You can see an example of the poc I did for this here: #482 although I'm not leveled up enough with angular to know how to pass down/bubble up the selected count to the right scope, but that's a solvable problem. Also, I have tweaked the css to make the buttons look reasonable BUT they should probably be put in their own dive and made inline-block. But tbd. |
Currently the |
Thank you for the PR! I'll try to get to it this weekend 😁 |
Add 'select all' when batch tagging #446
User requested. Seems simple enough -- add a button in the manual tags tray ✅
The text was updated successfully, but these errors were encountered: