Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'select all' when batch tagging #446

Closed
whyboris opened this issue May 31, 2020 · 7 comments
Closed

Add 'select all' when batch tagging #446

whyboris opened this issue May 31, 2020 · 7 comments
Labels
good first issue Good for newcomers

Comments

@whyboris
Copy link
Owner

User requested. Seems simple enough -- add a button in the manual tags tray

@whyboris whyboris added the good first issue Good for newcomers label May 31, 2020
@jamesd35
Copy link

jamesd35 commented Jun 8, 2020

Hi, can I work on this feature?

@whyboris
Copy link
Owner Author

whyboris commented Jun 8, 2020

Thank you 🤝

I'm sometimes rather particular about the UI (user interface), so don't worry too much about making things look great / harmonious with the rest -- I can fix it up after your code merges in 👍

Please feel free to reach out with any questions -- I'm happy to help 🙌

jamesd35 pushed a commit to jamesd35/Video-Hub-App that referenced this issue Jul 1, 2020
jamesd35 pushed a commit to jamesd35/Video-Hub-App that referenced this issue Jul 1, 2020
@TheTacoScott
Copy link

Only suggestion for an addition here is: make the same button become "deselect all" once it has selected all, and maybe have the button have the format of "deselect all (<number_of_videos_selected>)" so we have a better understanding.

@TheTacoScott
Copy link

You can see an example of the poc I did for this here: #482

although I'm not leveled up enough with angular to know how to pass down/bubble up the selected count to the right scope, but that's a solvable problem.

Also, I have tweaked the css to make the buttons look reasonable BUT they should probably be put in their own dive and made inline-block. But tbd.

@whyboris
Copy link
Owner Author

Currently the deselect all can be accomplished by toggling the batch mode off.
I'm unsure about cramming too many buttons into the menu, but maybe deselect all is a worthwhile addition 🤔 thank you!
I especially like the "number selected" indicator 😁

@whyboris
Copy link
Owner Author

Thank you for the PR! I'll try to get to it this weekend 😁
No worries about CSS -- I'll get it to look harmonious with the rest of the app (according to my sometimes-picky preferences 😅 )

whyboris added a commit that referenced this issue Jul 26, 2020
Add 'select all' when batch tagging #446
@whyboris
Copy link
Owner Author

Thank you @jamesd35 for the feature addition #446 🙇 🎉 🤝 🦾

Cheers 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants