Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add tests #12

Open
willemml opened this issue Mar 16, 2021 · 0 comments
Open

Re-add tests #12

willemml opened this issue Mar 16, 2021 · 0 comments
Labels
test Related to automated tests.

Comments

@willemml
Copy link
Member

willemml commented Mar 16, 2021 •
edited
Loading

Fix internal tests. Most of them fail due to changes made in PR #10 due to the way saving hub/user data is now handled...

Write tests for all modules, all old tests were removed because they had stopped working with recent changes, once re-added they should be enforced and tests should be required for any new code when reasonable. Once tests are added PRs should be required to pass all tests and include tests for added code before being merged.
@willemml willemml added bug Something isn't working test Related to automated tests. labels Mar 16, 2021
@willemml willemml mentioned this issue Mar 16, 2021
Closed
@willemml willemml changed the title Fix tests Re-add tests Mar 18, 2021
@willemml willemml removed the bug Something isn't working label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test Related to automated tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@willemml