Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limiting? #25

Open
willemml opened this issue May 1, 2021 · 3 comments
Open

Rate limiting? #25

willemml opened this issue May 1, 2021 · 3 comments
Labels
api Related to the API discussion enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@willemml
Copy link
Member

willemml commented May 1, 2021

It would probably be a good idea to implement some sort of rate limiting, (prevent users from spamming, or denial of service by making high IO requests repeatedly (for example spamming messages in a channels, possibly filling the disk quite fast) and in relation to #19 making the server download and store new PGP public keys, again, rapidly filling the disk, maybe also message/public key pruning (very old messages are optionally deleted after a certain amount of time or when the disk gets full.

@willemml willemml added enhancement New feature or request help wanted Extra attention is needed api Related to the API discussion labels May 1, 2021
@willemml willemml added this to the 1.0.0 milestone May 1, 2021
@x4e
Copy link
Contributor

x4e commented May 1, 2021

Something like this? https://outcrawl.com/rust-redis-rate-limiting
Or maybe this would be better https://github.com/antifuchs/governor

@willemml
Copy link
Member Author

willemml commented May 6, 2021

Probably something more like governor?

@x4e
Copy link
Contributor

x4e commented May 6, 2021

Yeah I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the API discussion enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants