-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version check crashes with ValueError: invalid literal for int() with base 10: '0a0' for ipykernel 7.0.0a0 #827
Comments
Thanks, I didn't realize that was not a good pattern. I refrained from using any Python tooling because it was never clear to me what the best solution is. importlib.metadata now seems to be the standard way (says chatgpt), but that is Python >= 3.8. I do think we can make this more robust, thanks for the issue! |
packaging or not, as long as you try to go for the officially supported pattern at https://peps.python.org/pep-0440/ , you should be good on the Python side. |
FWIW, My bug about this jupyterlite/pyodide-kernel#140 |
Anyways, can you please fix this. I really don't care if you use packaging or not, so I will modify the title. Thanks! |
Maybe this can be as easy as |
This line broke when pre-release is available (e.g.,
ipykernel==7.0.0a0
):solara/solara/server/kernel.py
Line 76 in eb8b827
If you switch to, say,
packaging.version.Version
check and take account of pre- or dev releases, then it would guard against such breakage.Thanks.
The text was updated successfully, but these errors were encountered: