Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

E-Mail Notification for locations #143

Closed
flegfleg opened this issue Apr 13, 2017 · 8 comments · Fixed by #172
Closed

E-Mail Notification for locations #143

flegfleg opened this issue Apr 13, 2017 · 8 comments · Fixed by #172

Comments

@flegfleg
Copy link
Member

BCC of Booking Confirmation to stations.

@sgrubsmyon
Copy link
Collaborator

Hi, at Bolle Bonn (https://bolle-bonn.de), we are currently switching to using the CB plugin. We are very interested in this feature because our booking stations usually want to be informed who is coming when to grab the item.

I would be willing to help in the implementation. Do you need any support?

Cheers!

@flegfleg
Copy link
Member Author

flegfleg commented Sep 3, 2017

Hey @sgrubsmyon, that´s great! Yes, support would be fantastic :)
I am currently working to re-organise the plugin files & classes so contributing will be easier (2/3 of the frontend are done). Will hopefully be finished in september.

@sgrubsmyon
Copy link
Collaborator

@flegfleg: Does that mean I should wait until you finished the re-organisation?
@anewholm: What have you done so far? I don't want to interfere with your work.

@sgrubsmyon
Copy link
Collaborator

Any updates on this? I see that there is a branch for the issue: https://github.com/wielebenwir/commons-booking/compare/email_notification_for_locations. I will try to use it and test if it works OK.

@flegfleg
Copy link
Member Author

Hey, unfortunately not right now. Still working on it. Hope this month.

@sgrubsmyon
Copy link
Collaborator

Please note that I have implemented this here: https://github.com/sgrubsmyon/commons-booking/tree/email_notification_for_locations and merged it into the master branch at https://github.com/sgrubsmyon/commons-booking/tree/master. The way it is implemented (similar to https://github.com/wielebenwir/commons-booking/tree/email_notification_for_locations) is by using a regex to extract all email addresses from the contact information field of the location. Like before, an email is sent to the user and the global BCC address, afterwards emails are sent to all the location email addresses found. I also implemented email delivery in case of booking cancellation here: https://github.com/sgrubsmyon/commons-booking/tree/email_on_cancel.

What I would like to still add: Check boxes in the settings that switch the email delivery to locations on and off.

@sgrubsmyon
Copy link
Collaborator

Update: there is now a check box to switch on/off the BCC email delivery to a location. See PR #172 or sgrubsmyon@70e875c.

@sgrubsmyon
Copy link
Collaborator

New update: Notification emails will also be sent when an admin deletes a booking from the booking table (only if the booking was not already canceled by the user and lies in the future). See #172 and https://github.com/sgrubsmyon/commons-booking.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.