Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API calls with badly parsed JSON should be caught gracefully #100

Open
timwaters opened this issue Jun 10, 2016 · 1 comment
Open

API calls with badly parsed JSON should be caught gracefully #100

timwaters opened this issue Jun 10, 2016 · 1 comment
Assignees

Comments

@timwaters
Copy link

{"data":{"type":"gcps","attributes":{"x":notANumber, "y":2,"lat":33.3,"lon":44.4,"map_id":2}}}
F, [2016-06-10T15:52:36.655067 #25856] FATAL -- :
ActionDispatch::ParamsParser::ParseError

@timwaters timwaters added the bug label Jun 10, 2016
@timwaters timwaters self-assigned this Jun 10, 2016
@timwaters
Copy link
Author

This is catching at the middleware level, and not in the application. I think its going to be a good idea to catch for all miss parsed json. So will change title

@timwaters timwaters added enhancement and removed bug labels Jun 13, 2016
@timwaters timwaters removed this from the IEG Wikimaps Warper 2.0 Final milestone Jun 13, 2016
@timwaters timwaters changed the title Server Error if json param is not a number, should catch before validation error API API calls with badly parsed JSON should be caught gracefully Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant