Script should follow user talk page redirects

[bardiharborow]

The script should not have made this edit, but instead should have followed the talk page redirect and left a message at the redirect target.

[enterprisey]

To reproduce: comment on a draft, with the "Notify user" option enabled, submitted by a user whose talk page is a redirect. Currently, the script will send a notice to the redirect, not the target of the redirect.

I'm pretty confident that all we need to do is add the parameter redirect: "true" to the API call that we use to notify users. The function that notifies users is notifyUsers in core.js, which uses editPage in core.js. While we could solve this by adding redirect: "true" to the request in editPage, that'll probably mess up other things. So, we should add a way for the callers of editPage to ask it to set redirect: "true", perhaps by handling options.followRedirect (to use a more obvious name than just "redirect").

[primefac]

As a note, Twinkle has the same issue so if this one gets solved it might be good to let Amory know so that it can be fixed in both locations.

[puneetdwivedi]

i want to work on this. how i can start

[enterprisey]

@puneetdwivedi Sorry! Not sure how I missed this. Here are instructions on getting set up; if you run into any trouble, post here or on the other help venues.

[enterprisey]

@puneetdwivedi How is this issue going? Please let me know if you've run into any problems.

[Ankur21980]

Hello! @enterprisey, I would like to work on this issue. Is it open yet?

[enterprisey]

@Ankur21980 hi! I would like to not assign this issue to someone else just yet - if you really want to work on this issue, please wait until the person currently assigned has not responded for another week. Alternatively, please ping me in a new topic in our Zulip channel - there are more issues that do not have the good-first-issue tag that might be easy to work on, depending on your level of experience.

@puneetdwivedi - are you still available to work on this issue? Unfortunately easy issues on this repository are not that easy to find, so please let me know whether or not you plan to continue working on this issue. If you do not make a comment on this issue with your status by a week from now (the 27th of March) I will assume you are not available, and will mark this issue as open for anyone to take.

[Prernajha2609]

hello @enterprisey, I would like to contribute to this project, I will need a little guidance to start.

[enterprisey]

@Prernajha2609 sure. Follow https://en.wikipedia.org/wiki/Wikipedia:WikiProject_Articles_for_creation/Helper_script/Contributing/Developer_setup and let me know if you get stuck.

[Prernajha2609]

how should I start after setting up the environment?

[NovemLinguae]

I imagine you'd want to pick an easy issue from the list of issues, write a patch, test it using https://test.wikipedia.org/, then submit a pull request.

[Prernajha2609]

Hey, can you suggest to me some beginner-friendly issues to work on?

…

On Sun, Jan 16, 2022 at 4:22 PM NovemLinguae ***@***.***> wrote: I imagine you'd want to pick an easy issue from the list of issues <https://github.com/WPAFC/afch-rewrite/issues>, write a patch, test it using https://test.wikipedia.org/, then submit a pull request <https://www.google.com/search?q=how+to+submit+a+pull+request+on+github>. — Reply to this email directly, view it on GitHub <#90 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASOF6GB4KUWK3EMQB35YAKLUWKPNZANCNFSM4EPAJS7A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[NovemLinguae]

Mentioned today by Mathglot at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Bug_in_AFCH_for_renamed_users

[primefac]

Is #99 a duplicate of this issue?

[NovemLinguae]

Mentioned today by Star Mississippi at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Script_question%2Fbug%3F

[NovemLinguae]

These two patches did not fix the issue apparently.

Steps to reproduce:

• submit -> someone else -> NovemBot
• decline
• reason: v
• comment: test
• tick notify user
• tick invite to teahouse
• decline

What happens?

• https://en.wikipedia.org/w/index.php?title=User_talk:NovemBot&diff=prev&oldid=1220358700

What should happen instead?

• comment should be on User talk:Novem Linguae, not User talk:NovemBot
• the comment is invisible due to the redirect above it

[NovemLinguae]

Will spin the bug out into its own ticket. #349