Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling $(x).uls() with new options doesn't update options #34

Open
bvibber opened this issue Nov 10, 2012 · 2 comments
Open

Calling $(x).uls() with new options doesn't update options #34

bvibber opened this issue Nov 10, 2012 · 2 comments
Assignees
Labels

Comments

@bvibber
Copy link
Contributor

bvibber commented Nov 10, 2012

For the Wikipedia PhoneGap app we need to be able to reinitialize options on the ULS.

In this case we need to update both the 'languages' object with a different set of languages, and the 'onSelect' callback.

Currently I'm attempting to reuse the existing ULS but simply reinit with $.uls().

If this isn't meant to be supported, then I'll need to be able to initialize and then discard the ULS, so I can create a new one safely... is that the right thing to do here?

@bvibber
Copy link
Contributor Author

bvibber commented Nov 10, 2012

One problem with creating a new fresh ULS is that the old <div class="uls-menu"> stays around... I can remove it manually perhaps, but have to know about it so it doesn't just eat up more memory in the DOM.

@ghost ghost assigned santhoshtr Nov 19, 2012
@amire80
Copy link
Contributor

amire80 commented May 7, 2013

@Brion if this only for PhoneGap and the PhoneGap app is being phased out, can this be closed? Or is this relevant for anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants