Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH is reloaded by default even if sshd_manage_service is set to false #236

Open
Ouack23 opened this issue May 7, 2023 · 1 comment
Open
Assignees
Labels
docs Documentation issue

Comments

@Ouack23
Copy link

Ouack23 commented May 7, 2023

Hello,

The documentation states that :

* `sshd_allow_reload`

If set to *false*, a reload of sshd wont happen on change. This can help with
troubleshooting. You'll need to manually reload sshd if you want to apply the
changed configuration. Defaults to the same value as `sshd_manage_service`.
(Except on AIX, where `sshd_manage_service` is default *false*, but
`sshd_allow_reload` is default *true*)

but the default variables set sshd_allow_reload to true : https://github.com/willshersystems/ansible-sshd/blob/master/defaults/main.yml#L14

So either the documentation is wrong and should be corrected, or the defaults file should be changed like this:

# If the below is false, don't reload the ssh daemon on change
- sshd_allow_reload: true
+ sshd_allow_reload: "{{ sshd_manage_service }}"

Thank you for reading :)

@Jakuje
Copy link
Collaborator

Jakuje commented May 15, 2023

When this was introduced in bcd864f, the documentation was matching the code. But it is "broken" since 43ed7c1 which dropped the assignment.

I am worried that the problem with such assignment might have issues with the variable precedence (would have to double-check though). Do you want to open a PR with this change, ideally also with a reproducer tests to verify that it works as expected in the testing environment (probably only by checking variables as they are based on containers and do not have services running)?

@mattwillsher mattwillsher self-assigned this Sep 4, 2024
@mattwillsher mattwillsher added the docs Documentation issue label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issue
Projects
None yet
Development

No branches or pull requests

3 participants