Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(linting): update variable names to include sshd_ prefix #246

Open
mattwillsher opened this issue Aug 8, 2023 · 3 comments
Open

chore(linting): update variable names to include sshd_ prefix #246

mattwillsher opened this issue Aug 8, 2023 · 3 comments
Labels
coding-standards Items related to coding standards that do not affect functionality dependencies Pull requests that update a dependency file

Comments

@mattwillsher
Copy link
Member

Var names should be prefixed with role name to pass lint checks.

If no time to work on this check can be disabled for now.

@Jakuje
Copy link
Collaborator

Jakuje commented Sep 7, 2023

This was disabled in 34be8e5 (#248) if I see right so I would consider this done. I think we can not accommodate this lint requirement.

@mattwillsher
Copy link
Member Author

The lint issue I've come across recently on a new role but try as I might I couldn't get the name to comply.
I do believe that we should conform to this rule, though, as it's effectively a variable scoping challenge.

I'll leave this open for now as a reminder to myself.

@mattwillsher mattwillsher changed the title chore: fix var names chore(linting): update variable names to include sshd_ prefix Sep 4, 2024
@spetrosi
Copy link
Contributor

spetrosi commented Sep 4, 2024

In system roles, we deprecated old variables by printint a message to users who use those old variables, and then setting the correct variable name, see https://github.com/linux-system-roles/mssql/blob/main/tasks/main.yml#L12-L25
Then, maybe in a couple years, we can remove the deprecated variable completely.

@mattwillsher mattwillsher added bug Defect that causes the role not to function as documented/expected. coding-standards Items related to coding standards that do not affect functionality dependencies Pull requests that update a dependency file and removed bug Defect that causes the role not to function as documented/expected. labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding-standards Items related to coding standards that do not affect functionality dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants