From 7f84f110debcaf02e812e25a1287d2d9e0597ac3 Mon Sep 17 00:00:00 2001 From: Stephen Buchanan Date: Mon, 12 Jun 2017 11:53:04 +0200 Subject: [PATCH 1/2] Fixed grammar, spelling, in README in a few places --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index b81f68b..edf215c 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # omxplayer-controll -Controll omxplayer with native dbus +Control omxplayer with native dbus ## Installation @@ -13,7 +13,7 @@ npm install omxplayer-controll [--save] ## Usage -Short example running a video getting the status every 5 seconds and listeing to the aboutToFinis signal +Short example running a video getting the status every 5 seconds and listening to the aboutToFinish signal ```js var omxp = require('omxplayer-controll'); @@ -68,11 +68,11 @@ omxp.setAspectMode(function(err){}); ``` ### Other commands -Change de Alpha of the current window the value must be between 0 and 255 +Change the Alpha of the current window the value; must be between 0 and 255 ```js omxp.setAlpha(alpha_value, function(err){}); ``` -Set the position of the window, only works in non full screen. +Set the position of the window; only works in non full screen. ```js omxp.setVideoPos(x1, y1, x2, y2, function(err){}); ``` @@ -80,7 +80,7 @@ Crop the video inside the window. ```js omxp.setVideoCropPos(x1, y1, x2, y2, function(err){}); ``` -Set the aspect mode for the video, must be one of the following: +Set the aspect mode for the video; must be one of the following: 'letterbox', 'fill', 'stretch', 'default' ```js omxp.setAspectMode(aspect, function(err){}); From d006aebe40869af4ec17a27d72bacba8dab276a8 Mon Sep 17 00:00:00 2001 From: Stephen Buchanan Date: Mon, 12 Jun 2017 12:10:17 +0200 Subject: [PATCH 2/2] fixed stray (duplicate?) function definition that was breaking everything --- index.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/index.js b/index.js index 15fd994..3260b98 100755 --- a/index.js +++ b/index.js @@ -162,13 +162,13 @@ module.exports.previousSubtitle = function(cb) { //checked return typeof cb === 'function' ? cb(err) : {}; }); }; -module.exports.hideSubtitles = function(cb) { //checked not tested (I have no subtitles) - omx_dbus.method('Action', [30], function(err) { -module.exports.previousSubtitle = function(cb) { //checked - omx_dbus.method('Action', [10], function(err) { - return typeof cb === 'function' ? cb(err) : {}; - }); -}; +// module.exports.hideSubtitles = function(cb) { //checked not tested (I have no subtitles) +// omx_dbus.method('Action', [30], function(err) { +// module.exports.previousSubtitle = function(cb) { //checked +// omx_dbus.method('Action', [10], function(err) { +// return typeof cb === 'function' ? cb(err) : {}; +// }); +// }; module.exports.hideSubtitles = function(cb) { //checked not tested (I have no subtitles) omx_dbus.method('Action', [30], function(err) { return typeof cb === 'function' ? cb(err) : {};