Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwa: Enforce notifications to use the app #24

Open
AlexITC opened this issue Oct 12, 2020 · 0 comments
Open

pwa: Enforce notifications to use the app #24

AlexITC opened this issue Oct 12, 2020 · 0 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@AlexITC
Copy link
Contributor

AlexITC commented Oct 12, 2020

The core functionality is to notify users about discounts, hence, it makes no much sense to keep notifications disabled, let's prevent the app usage until the notifications are enabled if the browser supports those (Safari doesn't), on Safari, we can leave the basic functionality enabled with the proper disclaimer.
@AlexITC AlexITC added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest labels Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexITC