From 04b525f124dd38d7cb083a24cfadf22702b8c392 Mon Sep 17 00:00:00 2001 From: BrooklynKing Date: Mon, 4 Mar 2019 15:01:42 +0200 Subject: [PATCH] fix: removing @ts-ignore from everywhere except tests --- package.json | 1 + src/adapters/dash.ts | 5 ++--- src/adapters/hls.ts | 1 - src/core/player-facade.ts | 9 ++++----- src/modules/playback-engine/adapters/native.ts | 4 ++-- src/modules/ui/core/extendStyles.ts | 1 - src/typings/internals.d.ts | 2 ++ 7 files changed, 11 insertions(+), 12 deletions(-) diff --git a/package.json b/package.json index 5b4cfe1d..86fa762e 100644 --- a/package.json +++ b/package.json @@ -74,6 +74,7 @@ "@babel/types": "7.0.0-beta.46", "@types/chai": "^4.1.7", "@types/chance": "^1.0.1", + "@types/classnames": "^2.2.7", "@types/hls.js": "^0.10.2", "@types/mocha": "^5.2.5", "@types/node": "^10.12.3", diff --git a/src/adapters/dash.ts b/src/adapters/dash.ts index 50fe9055..78ff5e33 100644 --- a/src/adapters/dash.ts +++ b/src/adapters/dash.ts @@ -1,4 +1,3 @@ -//@ts-ignore import { MediaPlayer } from 'dashjs/build/es5/index_mediaplayerOnly'; import { getNearestBufferSegmentInfo } from '../utils/video-data'; @@ -53,8 +52,8 @@ export default class DashAdapter implements IPlaybackAdapter { get currentUrl() { return this.mediaStream.url; } - //@ts-ignore - get syncWithLiveTime() { + + get syncWithLiveTime(): any { // TODO: implement syncWithLiveTime for `dash` return undefined; } diff --git a/src/adapters/hls.ts b/src/adapters/hls.ts index 7d811ebe..e5a8ecfd 100644 --- a/src/adapters/hls.ts +++ b/src/adapters/hls.ts @@ -1,4 +1,3 @@ -//@ts-ignore import HlsJs from 'hls.js/dist/hls.light'; import { diff --git a/src/core/player-facade.ts b/src/core/player-facade.ts index 4a9bb1a8..bfca8e50 100644 --- a/src/core/player-facade.ts +++ b/src/core/player-facade.ts @@ -4,11 +4,10 @@ import { PLAYER_API_PROPERTY } from '../core/player-api-decorator'; import { IThemeConfig } from '../modules/ui/core/theme'; export default class Player { - //@ts-ignore - private _config: IPlayerConfig; - private _scope: Container; - private _defaultModules: { [id: string]: any }; - private _additionalModules: { [id: string]: any }; + protected _config: IPlayerConfig; + protected _scope: Container; + protected _defaultModules: { [id: string]: any }; + protected _additionalModules: { [id: string]: any }; private _destroyed: boolean; constructor( diff --git a/src/modules/playback-engine/adapters/native.ts b/src/modules/playback-engine/adapters/native.ts index d2d12171..d3281cad 100644 --- a/src/modules/playback-engine/adapters/native.ts +++ b/src/modules/playback-engine/adapters/native.ts @@ -46,8 +46,8 @@ export default function getNativeAdapterCreator( get currentUrl() { return this.mediaStreams[this.currentLevel].url; } - //@ts-ignore - get syncWithLiveTime() { + + get syncWithLiveTime(): any { // TODO: implement syncWithLiveTime for `native` return undefined; } diff --git a/src/modules/ui/core/extendStyles.ts b/src/modules/ui/core/extendStyles.ts index d02f464f..02ac348f 100644 --- a/src/modules/ui/core/extendStyles.ts +++ b/src/modules/ui/core/extendStyles.ts @@ -1,4 +1,3 @@ -//@ts-ignore import classnames from 'classnames'; import { IStyles } from './types'; diff --git a/src/typings/internals.d.ts b/src/typings/internals.d.ts index 8f5e8715..51176ff0 100644 --- a/src/typings/internals.d.ts +++ b/src/typings/internals.d.ts @@ -1,3 +1,5 @@ declare module '*.scss'; declare module '*.svg'; declare module '*.dot'; + +declare module 'dashjs/build/es5/index_mediaplayerOnly';