Skip to content
This repository has been archived by the owner on Nov 1, 2019. It is now read-only.

Checkbox readme doc needs elements image #473

Open
abumami opened this issue Oct 16, 2017 · 7 comments
Open

Checkbox readme doc needs elements image #473

abumami opened this issue Oct 16, 2017 · 7 comments

Comments

@abumami
Copy link
Contributor

abumami commented Oct 16, 2017

OK, so I know the checkbox is super simple, and doesn't really have elements (that's the plural). But, it does have an element (that's the singular), and therefore should have an elements image (if you want to nitpick, you can call it an "element image") to be consistent with the other component readme docs.

@arnonkehat
Copy link
Contributor

Didn't it have one previously?

@urik9
Copy link
Contributor

urik9 commented Oct 18, 2017

I'm not sure about stylable-components but core3-components checkbox has an element image that we can use:
https://github.com/wixplosives/core3-components/blob/master/specs/checkbox.md

@abumami
Copy link
Contributor Author

abumami commented Oct 18, 2017

I suspect it had an image, but I would have to check archeological ruins to be sure. The core image that @urik9 is referring to is a behavior image and not strictly an elements image.

Seems to me that an older image (if it exists) would be OK, but I can't assume so. I just want to be sure that the image reflects the newest spec.

@abumami
Copy link
Contributor Author

abumami commented Oct 18, 2017

Just did some archeological spelunking (backups, drafts, older versions, etc) and could not find an elements image for checkbox.

@arnonkehat
Copy link
Contributor

@urik9 your call. are you happy with what was in c3c? i think it could use standardization with the same app @maksymc is using for these drawings. though i have no clue what that is :)

@abumami
Copy link
Contributor Author

abumami commented Oct 19, 2017

@arnonkehat Good point re: standardizing app for the drawings. I mentioned early on that it drives me crazy that the drawings all have a different look. It seems like everyone is using a different drawing app. Would be nice if we could agree on one that satisfies everyone.

@arnonkehat
Copy link
Contributor

@maksymc @urik9 @LeonidLevi can we agree on such a tool?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants