Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running upgrade un-pins dependencies #520

Open
tzachbon opened this issue Dec 21, 2022 · 2 comments
Open

Running upgrade un-pins dependencies #520

tzachbon opened this issue Dec 21, 2022 · 2 comments

Comments

@tzachbon
Copy link
Contributor

tzachbon commented Dec 21, 2022

When running upgrade it also "un-pins" a version even though it wasn't upgraded (also to upgraded requests).

image

It's a little unexpected. Shouldn't it keep the request status (minor, patch, pinned)?

@AviVahl
Copy link
Contributor

AviVahl commented Dec 21, 2022

It's actually on purpose. Whether it is correct to do so, could be argued... Especially in a semver ecosystem and when making use of lock files.

You can tell pleb to ignore specific dependencies using pleb.config.js/mjs: https://github.com/wixplosives/pleb#configuration-file

@tzachbon
Copy link
Contributor Author

It's actually on purpose. Whether it is correct to do so, could be argued... Especially in a semver ecosystem and when making use of lock files.

You can tell pleb to ignore specific dependencies using pleb.config.js/mjs: wixplosives/pleb#configuration-file

I agree with you, but there could be a case where an installed library would like a specific version, and we know it can't control its user's lock file so the author has to pin the version in the package json file. In that case, the library author can't use pleb to upgrade it and would have to do it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants