Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating and Updating the RepPointsServer #5

Closed
serapath opened this issue Nov 11, 2015 · 3 comments
Closed

Creating and Updating the RepPointsServer #5

serapath opened this issue Nov 11, 2015 · 3 comments

Comments

@serapath
Copy link
Member

Proposal

  • Every update to the RepPointsServer should be made as a Pull Request and not directly pushed to this repository, so we can discuss and agree on the update before we merge it.
@Nasdneb
Copy link
Contributor

Nasdneb commented Nov 11, 2015

I agree

@ninabreznik
Copy link
Member

Hm, saw this to late this time, but will do it next time.

@serapath
Copy link
Member Author

@Nasdneb
I checked the code, it's quite some lines of code already and at least the engine start to become hard to read. I don't know how to keep it simple, but maybe a specification driven approach would be nicer.

So in this or another issue - probably in a seperate issue, each source file of the Server could be described and maybe it's possible to split the code into many files, so that no file gets longer then maybe 10-30 lines of code... I don't know what would be a good number, but require('./filename.js') might be our friend here :-)

Usually I create the file structure like:

var repository = { }
repositor['source/'] = {
  'node_modules/' : {
    'api.js': '...file content...',
    'engine.js': '...file content...',
    'rest_api.js': '...file content...',
    'data/' : {
      'journal.js': '...file content...', // js files allow comments like this one
      'rules.js': '...file content...'
    }
  }
}

UPDATE:
The latest updates are to be found here: #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants