-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBF follow-ups #853
Comments
We can also check if any directly conflicting transactions are spending unconfirmed change and include these unconfirmed coins as candidates for the replacement transaction (#826 (comment)). |
We should add ancestor info to coin selection candidates when creating a replacement to ensure we pay extra for any parent transactions that have a lower feerate (#873 (comment)). |
We should support RBF on a recovery transaction. Currently, the RBF candidate coins all have their sequence set to |
Tried to address the second bullet in the description with #1186. |
8be0d98 commands: add minimum feerate to TooLowFeerate error message (Aaron Carlucci) Pull request description: This PR adds the minimum feerate value into the `TooLowFeerate` error message for additional context. Addresses the second bullet point in #853. ACKs for top commit: jp1ac4: ACK 8be0d98. Thanks! Tree-SHA512: 3a0e9c69ddb40433faf1e58c16dfee0212641b34478eddeda99388ebf82e2fb466633ab8f79c9bb0bb784f4a46807aa0a5abd65b9d92506144b84addb01dfdd8
I updated the issue description to include Michael's comments. I also divided it in different tasks and marked the second one as completed as per @aaroncarlucci's PR #1186 which was merged (thanks!) |
See #1255. |
Here are a couple things which didn't warrant holding up the PR but would be nice to have:
Expand the explicit-RBF-signaling sanity check to all conflicting transactions (commands: add
rbfpsbt
command #816 (comment))The "feerate too low" error could include the minimum feerate to be more helpful (commands: add
rbfpsbt
command #816 (comment))Added after @jp1ac4 comments:
@jp1ac4 feel free to suggest more.
The text was updated successfully, but these errors were encountered: