Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBF follow-ups #853

Open
1 of 5 tasks
darosior opened this issue Dec 7, 2023 · 6 comments
Open
1 of 5 tasks

RBF follow-ups #853

darosior opened this issue Dec 7, 2023 · 6 comments
Labels
Daemon / Liana library This is about lianad or the liana library (not the GUI) Enhancement Improving an existing functionality Good first issue Good for newcomers

Comments

@darosior
Copy link
Member

darosior commented Dec 7, 2023

Here are a couple things which didn't warrant holding up the PR but would be nice to have:

Added after @jp1ac4 comments:

@jp1ac4 feel free to suggest more.

@darosior darosior added Good first issue Good for newcomers Daemon / Liana library This is about lianad or the liana library (not the GUI) Enhancement Improving an existing functionality labels Dec 7, 2023
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Dec 13, 2023

We can also check if any directly conflicting transactions are spending unconfirmed change and include these unconfirmed coins as candidates for the replacement transaction (#826 (comment)).

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Mar 11, 2024

We should add ancestor info to coin selection candidates when creating a replacement to ensure we pay extra for any parent transactions that have a lower feerate (#873 (comment)).

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Jun 20, 2024

We should support RBF on a recovery transaction. Currently, the RBF candidate coins all have their sequence set to None.

@aaroncarlucci
Copy link

Tried to address the second bullet in the description with #1186.

darosior added a commit that referenced this issue Jul 29, 2024
8be0d98 commands: add minimum feerate to TooLowFeerate error message (Aaron Carlucci)

Pull request description:

  This PR adds the minimum feerate value into the `TooLowFeerate` error message for additional context. Addresses the second bullet point in #853.

ACKs for top commit:
  jp1ac4:
    ACK 8be0d98. Thanks!

Tree-SHA512: 3a0e9c69ddb40433faf1e58c16dfee0212641b34478eddeda99388ebf82e2fb466633ab8f79c9bb0bb784f4a46807aa0a5abd65b9d92506144b84addb01dfdd8
@nondiremanuel
Copy link
Collaborator

nondiremanuel commented Jul 29, 2024

I updated the issue description to include Michael's comments. I also divided it in different tasks and marked the second one as completed as per @aaroncarlucci's PR #1186 which was merged (thanks!)

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Sep 4, 2024

We should add ancestor info to coin selection candidates when creating a replacement to ensure we pay extra for any parent transactions that have a lower feerate (#873 (comment)).

See #1255.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daemon / Liana library This is about lianad or the liana library (not the GUI) Enhancement Improving an existing functionality Good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants