Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RBF for transactions broadcast from another wallet #854

Closed
darosior opened this issue Dec 7, 2023 · 2 comments · Fixed by #1558
Closed

RBF for transactions broadcast from another wallet #854

darosior opened this issue Dec 7, 2023 · 2 comments · Fixed by #1558
Assignees
Labels
Daemon / Liana library This is about lianad or the liana library (not the GUI) Enhancement Improving an existing functionality

Comments

@darosior
Copy link
Member

darosior commented Dec 7, 2023

At the moment the RBF mechanism introduced in #816 only supports referring to one of our PSBTs. It's possible a transaction involving our wallet was broadcast without us having the PSBT (think: threshold multisig), and we might want to RBF this transaction. Because it seems to be a pretty niche usecase, and because it wasn't clear what additional checks we'd need in this case, the first implementation did not support this.

However with the way it ended up being implemented i think it would not be too hard to support creating a RBF for transactions for which we don't have the PSBT: simply query the wallet transaction instead. @jp1ac4 anything i'm missing or otherwise to add here?

@darosior darosior added Daemon / Liana library This is about lianad or the liana library (not the GUI) Enhancement Improving an existing functionality labels Dec 7, 2023
@darosior darosior changed the title RBF for transactions we didn't broadcast RBF for transactions broadcast from another wallet Dec 7, 2023
@jp1ac4
Copy link
Collaborator

jp1ac4 commented Dec 7, 2023

I think that's right, we just need the transaction input and output, and so only a small change should be required here.

@pythcoiner
Copy link
Collaborator

one related issue happen to an user today: he remove its wallet while an tx was not confirmed, after reimprting it (tx still not confirmed), he cannot RBF beacuse the PSBT don't exists anymore

@jp1ac4 jp1ac4 self-assigned this Jan 29, 2025
@nondiremanuel nondiremanuel moved this from Todo to Done in Liana General Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daemon / Liana library This is about lianad or the liana library (not the GUI) Enhancement Improving an existing functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants