GUI: RBF: improve feerate text input

[darosior]

It might be better not to trim the feerate value as it's difficult to edit a single-digit value. It's not possible to delete the existing value and enter a new one and we have to instead add a second digit and delete the first.

Originally posted by @jp1ac4 in #852 (comment)

[faytey]

Hello is this issue still available, i'd love to work on it and get a bit more context thanks

[darosior]

#852 introduced support for RBF'ing unconfirmed transactions in the GUI. This is presented as a button you click which opens a modal for you to set the feerate of the new transaction. The text input for the feerate of the new transaction however gets trimmed as you edit it, which makes it difficult to edit single-digit values.

@jp1ac4 what do you think a fix should be here? Simply using an untrimmed form::Form?

[jp1ac4]

Hi @faytey, thanks for offering to work on this issue.

I initially thought the problem was to do with trimming the form values:

liana/gui/src/app/view/transactions.rs

Line 247 in 903328f

form::Form::new_trimmed("", feerate, move |msg| {

But we don't have this issue on the normal Send page, which uses the same type of form:

liana/gui/src/app/view/spend/mod.rs

Line 172 in 903328f

form::Form::new_trimmed(

I think rather the problem is how we handle the feerate being edited. We only save the form value if it can be parsed as u64:

liana/gui/src/app/state/transactions.rs

Line 335 in 903328f

self.feerate_val.value = s;

But I think we should save the form value regardless of whether it can be parsed, and only its validity should depend on the result of parsing.

[jp1ac4]

Hi @faytey, are you still working on this issue?