Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all missing icons #227

Open
jfer-rubio opened this issue Dec 27, 2018 · 7 comments
Open

Add all missing icons #227

jfer-rubio opened this issue Dec 27, 2018 · 7 comments
Assignees
Labels

Comments

@jfer-rubio
Copy link
Contributor

We currently have only the following icons:

image

UX team have defined these:

image

@jfer-rubio
Copy link
Contributor Author

@wizeline/wz-tea-ux do you need any other icon?

@Rantelo
Copy link

Rantelo commented Jan 15, 2019

Hi guys.
I would like to start working on this issue.
Where can I find the svgs for the missing icons?

@jfer-rubio
Copy link
Contributor Author

jfer-rubio commented Jan 15, 2019

Hello @Rantelo, we download them from material's design catalog. Very manual from the moment. Here is a PR example https://github.com/wizeline/tea/pull/186/files (the design-system/src/index.html change is not needed but useful for debugging in local)

@Rantelo
Copy link

Rantelo commented Jan 15, 2019

All right then.
I'll start working on this.

@Rantelo
Copy link

Rantelo commented Jan 16, 2019

Hey guys!
I have worked with the majority of the icons so far.
Currently I have 3 blockers and I could use some help with them.

  1. I haven't being able to push my branch into this repo. The git messages says it could be due to permissions. image

I checked the repository name and it's correct [email protected]:wizeline/tea.git
I also checked my ssh passphrase and it's also correct.

I think that we have two options here:

  • I could fork the project, upload my updates into my fork and then submit the PR.
  • I could be added as a collaborator in the project, so I can push my own branches.
  1. For some reason, the new added icons are not showing in the documentation of catalog. I already added them into icons.md page and their box is showing, but the actual icon is not showing.

What I see in stencil dev-server:
image

What I see in catalog dev-server:
image

I believe that I'm missing some configuration. Any hints on this one?

  1. From the icons suggested by UX team, there are 3 that are missing (Book, Filter, Duplicate)
  • Book: I found another one pretty similar but with one page with no fill. I think is really close to the one defined by UX team so I added it to the bundle.
  • Filter: Not available in material.io as defined by UX team.
  • Duplicate: Also not available as defined by the team, though there is one that is pretty similar visually but different in concept. (The one defined by the team is a duplicate in general. The one that I found in material.io is file_copy )

Thanks for the help!

@jfer-rubio
Copy link
Contributor Author

@jugerardo @elbz can you help him with the third point?. I also want to know if we still going to have materialUI icons as our only source of icons?

@jugerardo
Copy link

@jfer-rubio We are using material but please use the assets in zeplin to implement them, don't replace any of them

https://zpl.io/aXGmGDp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants