Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Pathing #15

Open
RyanTimoney opened this issue Sep 10, 2018 · 1 comment
Open

Inconsistent Pathing #15

RyanTimoney opened this issue Sep 10, 2018 · 1 comment

Comments

@RyanTimoney
Copy link
Collaborator

Say we have the following tree:

.gitignore
.servicer
    services.yaml
    .pypirc
somefile.yaml

Paths should usually be relative to the root directory of the project. A credentials step looks like this:

steps:
  credentials:
    config:
      steps:
        - type: generate_pypi_config
          args:
            config:
              pypirc:
                path: ./.servicer/.pypirc
                servers:
                  ...

However, inclusions are currently executed relative to the .servicer directory.

  myservice:
    includes:
      path: ../somefile.yaml

Consistency would make this easier. Is there a reason for the different strategies?

@wmgroot
Copy link
Owner

wmgroot commented Sep 14, 2018

This is because it was assumed that servicer config files would all exist within the .servicer directory. It shouldn't be hard to either use the root project path, or alternatively the path of the file using the extends or includes key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants