Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Nested Steps #16

Open
RyanTimoney opened this issue Sep 11, 2018 · 0 comments
Open

Rename Nested Steps #16

RyanTimoney opened this issue Sep 11, 2018 · 0 comments

Comments

@RyanTimoney
Copy link
Collaborator

Currently, the term steps is being used at the Servicer level, and separately for things like the service adapters. This results in a service looking like this:

  docker_example:
    provider: gcloud
    service_type: docker_image
    steps:
      build:
        config:
          # The service adapter handles things nested at this level and deeper
          steps:
            - type: build
              args:
                image: demo-image
                dockerfile: Dockerfile

There's no way to recognize here that the steps nested within the service adapter have no relationship with the steps run at the top level of Servicer. It would improve readability to deprecate the service adapter steps with steps-sa, or similar, to clearly distinguish them from the steps run at the top level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant