Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VkCtx::Calibrate can be stuck in an infinite loop, freezing our render thread #872

Open
VincentHypx opened this issue Aug 28, 2024 · 0 comments

Comments

@VincentHypx
Copy link

VincentHypx commented Aug 28, 2024

After roughly 3 minutes of running the profiler on a laptop using the vulkan backend, the calibration values returned by m_vkGetCalibratedTimestampsEXT are never below the expected deviation, therefore it stays stuck in this loop.

Our project is very demanding, my current guess is that the video card changes behaviour because of the workload
Either it's struggling with our render demands or it enters a different energy mode, who knows.
Either way, it ends up delivering less accurate calibration results.

Would it be possible to add a retry approach, so attempt to pass the desired deviation threshold and if it fails after say 8 retries, it would chose the result that had the least amount of deviation?

Of course, if you have a better solution, it would be more than welcome.

Here's the while loop in question
https://github.com/wolfpld/tracy/blob/e26c34346bed7667118ff6dce6b1aa118701efa3/public/tracy/TracyVulkan.hpp#L357C1-L363C42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant