Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic property deprecation warnings with PHP8.2 under Facebook tab on Edit Products page #2611

Closed
2 tasks done
krutidugade opened this issue Aug 8, 2023 · 1 comment · Fixed by #2606
Closed
2 tasks done

Comments

@krutidugade
Copy link
Contributor

🔎 Isolate the bug

  • I have confirmed this occurs in the most recent version of WordPress, WooCommerce, and Facebook for WooCommerce.
  • I have confirmed this occurs when only WooCommerce and Facebook for WooCommerce are active and when using a default WordPress or WooCommerce theme.

✍️ Describe the bug

Found as a result of PHP8.2 compatibility testing. I see following deprecation warnings on Edit Product page under Facebook tab. The warnings can be seen at the bottom.

🚶‍♀️ Steps to reproduce

  1. Change your site's PHP version to 8.2
  2. Install and activate Facebook for WooCommerce plugin
  3. Go to Products > Add New
  4. Scroll down to Facebook tab

✔️ Expected behavior

No warnings under the Facebook tab.

Actual Behaviour

You see the following warnings under the Facebook tab on Edit or Add New Product page.

Deprecated: Creation of dynamic property WooCommerce\Facebook\Admin\Enhanced_Catalog_Attribute_Fields::$page_type is deprecated in /var/www/html/wp-content/plugins/facebook-for-woocommerce/includes/Admin/Enhanced_Catalog_Attribute_Fields.php on line 31

Deprecated: Creation of dynamic property WooCommerce\Facebook\Admin\Enhanced_Catalog_Attribute_Fields::$term is deprecated in /var/www/html/wp-content/plugins/facebook-for-woocommerce/includes/Admin/Enhanced_Catalog_Attribute_Fields.php on line 32

Deprecated: Creation of dynamic property WooCommerce\Facebook\Admin\Enhanced_Catalog_Attribute_Fields::$product is deprecated in /var/www/html/wp-content/plugins/facebook-for-woocommerce/includes/Admin/Enhanced_Catalog_Attribute_Fields.php on line 33

Deprecated: Creation of dynamic property WooCommerce\Facebook\Admin\Enhanced_Catalog_Attribute_Fields::$category_handler is deprecated in /var/www/html/wp-content/plugins/facebook-for-woocommerce/includes/Admin/Enhanced_Catalog_Attribute_Fields.php on line 34

Screenshot

Screenshot 2023-08-08 at 5 02 49 PM
@ecgan
Copy link
Member

ecgan commented Aug 14, 2023

Fixed in PR #2606, closing this issue.

@ecgan ecgan closed this as completed Aug 14, 2023
@ecgan ecgan linked a pull request Aug 14, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants