Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use admin theme colors instead of hardcoded colors for common UI components #2058

Closed
eason9487 opened this issue Aug 16, 2023 · 0 comments · Fixed by #2059
Closed

Use admin theme colors instead of hardcoded colors for common UI components #2058

eason9487 opened this issue Aug 16, 2023 · 0 comments · Fixed by #2059
Assignees
@eason9487
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@eason9487
Copy link
Member

eason9487 commented Aug 16, 2023 •
edited
Loading

Project thread: peeuvX-Q4-p2

Expected behavior

Any hardcoded pink/purple colors or common UI components in WooCommerce Admin pages should use admin theme colors.

Actual behavior

After walking through all the pages of this extension, found these colors need to be adjusted:

Link color changes from gray to purple when hovering

1

Active dot in the page control

2

Icon color does not change when hovering

6

Native <select>

💡 This color is specified by WordPress core and should be fixed from upstream.

3

4

5
@eason9487 eason9487 added the type: enhancement The issue is a request for an enhancement. label Aug 16, 2023
@eason9487 eason9487 self-assigned this Aug 16, 2023
@eason9487 eason9487 mentioned this issue Aug 17, 2023
Merged
@eason9487 eason9487 changed the title Use admin theme colors instead of hardcoded pink/purple colors Use admin theme colors instead of hardcoded colors for common components Aug 17, 2023
@eason9487 eason9487 changed the title Use admin theme colors instead of hardcoded colors for common components Use admin theme colors instead of hardcoded colors for common UI components Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eason9487 eason9487

Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply consistent admin theme colors to common UI components woocommerce/google-listings-and-ads
1 participant
@eason9487