Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility testing with Woo 9.3 Beta #458

Closed
11 tasks
vikrampm1 opened this issue Aug 28, 2024 · 0 comments · Fixed by #461
Closed
11 tasks

Compatibility testing with Woo 9.3 Beta #458

vikrampm1 opened this issue Aug 28, 2024 · 0 comments · Fixed by #461
Assignees
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: task The issue is an internally driven task (e.g. from another A8c team).
Milestone

Comments

@vikrampm1
Copy link
Contributor

vikrampm1 commented Aug 28, 2024

The goal for this project is to test WooCommerce 9.3 Beta compatibility with detailed steps for each task of this project noted below:

  • Bump WooCommerce “WC Tested up to” to version 9.3 in plugin.php and GitHub Actions (if applicable).
  • Bump WooCommerce “WC requires at least” to version 9.1 (as this matches the expected L-2 support policy) in plugin.php and GitHub Actions (if applicable).
  • Check/Bump WordPress “Requires at least” to version 6.4 (to match the WP minimum in WC 9.1 in plugin.php and GitHub Actions (if applicable)).
  • Check/Bump PHP “Requires PHP” to version 7.4 (to match the PHP minimum in WC 9.1 in plugin.php and GitHub Actions (if applicable)).
  • Check other files where the version needs to be bumped - For this the main thing to look for is the function version_compare and then see if we're checking WC versions there or something else. Some plugins also define what WC version we support (sometimes as a minimum) in a constant (see Square as an example). There's not always consistent naming on those constants so really the easiest way to find these is to search the codebase for the version string. Search the last few releases to catch them all. Also, suggest looking at the last PR that bumped versions to copy what was done for those.
  • Check if the following needs to be updated: MINIMUM_PHP_VERSION, MINIMUM_WP_VERSION, MINIMUM_WC_VERSION
  • Scan for any conditional checks that may be in the code that can be removed with these “Tested up to” and minimum/"Requires" bumps.
  • Add compatibility fixes, where necessary
  • If e2e tests pass then move the issue to UAT. If e2e tests fail, see if that's an issue with the test or compatibility with WC.

After bumping versions in a PR, we will ensure that e2e tests and overall plugin functionality continues to work as expected via regression testing following defined critical flows (if plugin functional compatibility changes were required).

Project success metrics:

  • PR(s) merged to trunk
  • Release ZIP created and tagged for release

Sample Changelog entry could then be:

Dev - Bump WooCommerce "tested up to" version 9.3.
Dev - Bump WooCommerce minimum supported version to 9.1.
Dev - Bump WordPress minimum supported version to 6.4.
Dev - Bump PHP minimum supported version to 7.4.

@vikrampm1 vikrampm1 added priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: task The issue is an internally driven task (e.g. from another A8c team). labels Aug 28, 2024
@vikrampm1 vikrampm1 added this to the Future Release milestone Aug 28, 2024
@vikrampm1 vikrampm1 modified the milestones: Future Release, 1.2.9 Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants