Skip to content
This repository has been archived by the owner on Jul 12, 2024. It is now read-only.

REST API: Handle Custom Product Tables #1143

Closed
psealock opened this issue Dec 20, 2018 · 4 comments
Closed

REST API: Handle Custom Product Tables #1143

psealock opened this issue Dec 20, 2018 · 4 comments

Comments

@psealock
Copy link
Collaborator

In reworking the Categories Report query, I came across this comment:

// Group by category without a helper table, worst case we add it and change the SQL afterwards.
// Other option would be a join with wp_post and taxonomies, but a) performance might be bad, b) how to handle custom product tables?

#1135 (review) satisfies the performance question, but the custom product tables question remains and this issue will serve as a place to track that question.

Also, what affect will that have on the Products Report Query?

@joshuatf
Copy link
Contributor

@peterfabian I think you might have left this comment. Do you have more info on this?

I think it may be referring to this plugin and I would imagine that would change how most of our data stores handle population.

@peterfabian
Copy link
Contributor

I don't have much more info, besides the fact that our plugin won't work with custom product table plugin (exactly the one linked by @joshuatf ) and we should probably think about how we could make it work or if that's something for future version.

@claudiosanches
Copy link
Contributor

we should probably think about how we could make it work or if that's something for future version.

We need update the Product Tables plugin and hook into reports Data Store to make it work.
When getting any data from the WC_Product class should be just fine, but since we are doing directly queries we should update that plugin too.

My advice is to close this issue for now and open another in Product Tables plugin repository.

@timmyc
Copy link
Contributor

timmyc commented Jun 11, 2019

My advice is to close this issue for now and open another in Product Tables plugin repository.

Closing in favor of woocommerce/woocommerce-product-tables-feature-plugin#147

@timmyc timmyc closed this as completed Jun 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants