diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt index a3cb10b7592..a76452a5460 100644 --- a/RELEASE-NOTES.txt +++ b/RELEASE-NOTES.txt @@ -3,6 +3,7 @@ *** For entries which are touching the Android Wear app's, start entry with `[WEAR]` too. 20.8 ----- +- [*] [Payments] Fix learn more link for Pay in Person option in payments settings [https://github.com/woocommerce/woocommerce-android/pull/12786] - [*] Added objective selection in the blaze campaign creation flow [https://github.com/woocommerce/woocommerce-android/pull/12781] 20.7 diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/AppUrls.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/AppUrls.kt index 224a9effb7f..db28fd289cf 100644 --- a/WooCommerce/src/main/kotlin/com/woocommerce/android/AppUrls.kt +++ b/WooCommerce/src/main/kotlin/com/woocommerce/android/AppUrls.kt @@ -82,10 +82,7 @@ object AppUrls { "https://woocommerce.com/document/woopayments/in-person-payments/tap-to-pay-android/" const val WOOCOMMERCE_LEARN_MORE_ABOUT_PAYMENTS_CASH_ON_DELIVERY = - "https://woocommerce.com/document/getting-started-with-in-person-payments-with-woocommerce-payments/" + - "#add-cod-payment-method" - const val STRIPE_LEARN_MORE_ABOUT_PAYMENTS_CASH_ON_DELIVERY = - "https://woocommerce.com/document/stripe/accept-in-person-payments-with-stripe/#section-8" + "https://woocommerce.com/document/cash-on-delivery/" const val WOOCOMMERCE_PURCHASE_CARD_READER_IN_COUNTRY = "https://woocommerce.com/products/hardware/" diff --git a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProvider.kt b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProvider.kt index 942b5235978..f77c32ce279 100644 --- a/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProvider.kt +++ b/WooCommerce/src/main/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProvider.kt @@ -27,10 +27,7 @@ class LearnMoreUrlProvider @Inject constructor( } } LearnMoreUrlType.CASH_ON_DELIVERY -> { - when (preferredPlugin) { - STRIPE_EXTENSION_GATEWAY -> AppUrls.STRIPE_LEARN_MORE_ABOUT_PAYMENTS_CASH_ON_DELIVERY - WOOCOMMERCE_PAYMENTS, null -> AppUrls.WOOCOMMERCE_LEARN_MORE_ABOUT_PAYMENTS_CASH_ON_DELIVERY - } + AppUrls.WOOCOMMERCE_LEARN_MORE_ABOUT_PAYMENTS_CASH_ON_DELIVERY } } } diff --git a/WooCommerce/src/test/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProviderTest.kt b/WooCommerce/src/test/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProviderTest.kt index d7637962955..3218383ae1e 100644 --- a/WooCommerce/src/test/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProviderTest.kt +++ b/WooCommerce/src/test/kotlin/com/woocommerce/android/ui/payments/cardreader/LearnMoreUrlProviderTest.kt @@ -62,7 +62,7 @@ class LearnMoreUrlProviderTest { } @Test - fun `given preferred plugin WcPay, when providing learn more url for COD, then WcPay COD url returned`() { + fun `given preferred plugin WcPay, when providing learn more url for COD, then COD url returned`() { // GIVEN whenever(appPrefsWrapper.getCardReaderPreferredPlugin(any(), any(), any())) .thenReturn(WOOCOMMERCE_PAYMENTS) @@ -75,7 +75,7 @@ class LearnMoreUrlProviderTest { } @Test - fun `given preferred plugin null, when providing learn more url for COD, then WcPay COD learn more url returned`() { + fun `given preferred plugin null, when providing learn more url for COD, then COD learn more url returned`() { // GIVEN whenever(appPrefsWrapper.getCardReaderPreferredPlugin(any(), any(), any())) .thenReturn(null) @@ -88,7 +88,7 @@ class LearnMoreUrlProviderTest { } @Test - fun `given preferred plugin Stripe, when providing learn more url for COD, then Stripe COD url returned`() { + fun `given preferred plugin Stripe, when providing learn more url for COD, then COD learn more url returned`() { // GIVEN whenever(appPrefsWrapper.getCardReaderPreferredPlugin(any(), any(), any())) .thenReturn(STRIPE_EXTENSION_GATEWAY) @@ -97,6 +97,6 @@ class LearnMoreUrlProviderTest { val res = provider.provideLearnMoreUrlFor(CASH_ON_DELIVERY) // THEN - assertThat(res).isEqualTo(AppUrls.STRIPE_LEARN_MORE_ABOUT_PAYMENTS_CASH_ON_DELIVERY) + assertThat(res).isEqualTo(AppUrls.WOOCOMMERCE_LEARN_MORE_ABOUT_PAYMENTS_CASH_ON_DELIVERY) } }