Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post-NUX] Merge "Debug Mode" and "Enable Logging" #130

Open
faisal-alvi opened this issue May 23, 2024 · 0 comments
Open

[Post-NUX] Merge "Debug Mode" and "Enable Logging" #130

faisal-alvi opened this issue May 23, 2024 · 0 comments
Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.

Comments

@faisal-alvi
Copy link
Member

Describe the bug

As discussed in #105 (comment):

These two settings are independent of each other and have different functionalities:

Debug Mode: Toggles logging Square payment gateway errors on/off
Enable Logging: Toggles logging Square connection, import & sync errors on/off

Given this, merchants can have "Enable Logging" turned off and have Debug mode set to "Save to log" and errors from the checkout will still be logged.

image

So we have internally decided to merge these settings together rather than keeping them separate as they seem to do more or less the same thing and we'll do that in a separate PR.

To reproduce

n/a

Screenshots

added above

Expected behavior

Both settings should be merged, their current usage should also be altered after the merge.

@faisal-alvi faisal-alvi added the type: enhancement The issue is a request for an enhancement. label May 23, 2024
@faisal-alvi faisal-alvi added this to the Future Release milestone May 23, 2024
@vikrampm1 vikrampm1 added the priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants