Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update $has_balance loop #168

Open
vikrampm1 opened this issue Jul 3, 2024 · 0 comments
Open

Update $has_balance loop #168

vikrampm1 opened this issue Jul 3, 2024 · 0 comments
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves technical debt of the project.

Comments

@vikrampm1
Copy link
Contributor

As noted in PR #142 (comment). The logic for $has_balance seems a little odd. $has_balance doesn't change between each looped element and so this whole loop could be avoided if ! $has_balance.
@vikrampm1 vikrampm1 added priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves technical debt of the project. labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: technical debt This issue/PR represents/solves technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vikrampm1