Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 4.8.2 #226

Closed
14 tasks done
vikrampm1 opened this issue Sep 27, 2024 · 4 comments · Fixed by #228
Closed
14 tasks done

Release version 4.8.2 #226

vikrampm1 opened this issue Sep 27, 2024 · 4 comments · Fixed by #228
Assignees
Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: task The issue is an internally driven task (e.g. from another A8c team).
Milestone

Comments

@vikrampm1
Copy link
Contributor

vikrampm1 commented Sep 27, 2024

This issue is for tracking the 4.8.2 release. Target release date: October 14 2024

Pre-release steps

Release steps

  • Branch: Starting from trunk, cut a release branch named release/4.8.2
  • Version bump: Bump the version number in woocommerce-square.php, package.json, package-lock.json and readme.txt to 4.8.2. In woocommerce-square.php update both the plugin "Version:" property and the plugin WC_SQUARE_VERSION constant
  • Update @since: Find all new @since x.x.x / @since n.e.x.t lines and update those with the new version number, 4.8.2
  • Generate changelog: Locally, generate the changelog by running the following Woorelease command: php woorelease.phar cl:generate --product_version=4.8.2 https://github.com/woocommerce/woocommerce-square/tree/trunk. Ensure the changelog updates look correct
  • Update changelog: Take the changelog generated from the previous step and update the release PR with those changes, both in the changelog.txt file and readme.txt file
  • Open PR: Open a new PR against trunk from the release branch, release/4.8.2
  • Run tests: On this release PR, add the label needs: qit default tests and needs: e2e testing. This will trigger the default QIT tests (activation, API and E2E) and our E2E tests. Ensure these tests pass as well as all other applicable tests
  • Merge: Merge the release PR into trunk
  • Prepare ZIP: Prepare the zip by running Woorelease locally on the trunk branch: php woorelease.phar build https://github.com/woocommerce/woocommerce-square/tree/trunk. Make sure you are running the proper versions of node, npm and composer to ensure the built files are consistent across releases. Versions can be found in package.json
  • Compare: Download the latest released zip and then run a diff compare against the generated zip, ensuring all expected changes are there (and no unexpected changes)
  • Test ZIP: Take the ZIP generated from the previous step and test this locally, ensuring version numbers look correct, the changelog looks correct and the plugin installs and activates properly
  • Attach ZIP: Attach the ZIP to this issue and ping the Automattic team in the #a8c-10up-woo-support channel to complete the release
@vikrampm1 vikrampm1 added priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: task The issue is an internally driven task (e.g. from another A8c team). labels Sep 27, 2024
@vikrampm1 vikrampm1 added this to the 4.8.2 milestone Sep 27, 2024
@dkotter
Copy link
Contributor

dkotter commented Sep 27, 2024

@vikrampm1 So the only PR here is the Woo 9.4 bump. Since Woo 9.4 isn't even released yet (scheduled for October 21) do we want to proceed with pushing this out? While there's no harm as far as I know in specifying a higher version than what is actually released, we are also bumping the minimum Woo and WP versions here and without 9.4 actually being released, seems that may be a little aggressive.

@vikrampm1
Copy link
Contributor Author

@dkotter I think you're right, we can hold this off until the actual release. The compat bumps for Square at least needed to go out asap so I've created the release even though we only have 1 PR merged but I think it can go out closer to the schedule date (October 21), unless @jeffpaul thinks otherwise.

@vikrampm1
Copy link
Contributor Author

Based on the discussion, I think we can proceed with this release? I just merged one other PR and there aren't any other PRs that will be ready anytime soon.

@dkotter dkotter mentioned this issue Oct 11, 2024
@dkotter dkotter reopened this Oct 14, 2024
@dkotter
Copy link
Contributor

dkotter commented Oct 14, 2024

@vikrampm1 This is ready for release:

woocommerce-square.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high The issue/PR is high priority—if affect lots of customers substantially, but not critically. type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants