Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert React component to functional component #1057

Closed
alexanmtz opened this issue Feb 7, 2024 · 30 comments
Closed

Convert React component to functional component #1057

alexanmtz opened this issue Feb 7, 2024 · 30 comments
Assignees
Milestone

Comments

@alexanmtz
Copy link
Member

Change the file './frontend/src/components/profile/skill.js' to a functional react component.

@Asin-Junior-Honore
Copy link

@alexanmtz please assign me this issue👨‍💻

@alexanmtz
Copy link
Member Author

Hey @Asin-Junior-Honore, we have this PR: #1058; you can continue from there; please check it out and test locally. You need to open the user skill page: https://gitpay.me/#/profile/user-account/skills

Let me know if you need any help

@Asin-Junior-Honore
Copy link

@alexanmtz when i test the site in my Browser locally it displays the landing page very well and clearly but when i try to login i get this message👇 although my internet is working fine
Screenshot (1)

@alexanmtz
Copy link
Member Author

@Asin-Junior-Honore, the local integration to log in via Github is not enabled by default, so please create an account with an e-mail and a password. The activation to activate your account locally is usually from e-mail, but locally, there's no mail server, so you will be able to activate your account by copying the activation link on your local server log.

@Asin-Junior-Honore
Copy link

@alexanmtz i am really sorry for the late response but could you please give more context on the required solution please🙏

@alexanmtz
Copy link
Member Author

@Asin-Junior-Honore register with a regular account using e-mail instead of Github locally, then go to your terminal when you ran the server and you will see the email content for account activation there, then you can copy and paste the link, then go to your skills section on: http://localhost:8082/#/profile/user-account/skills locally and you should open the page with any errors :-)

@Asin-Junior-Honore
Copy link

@alexanmtz I followed your instructions but am still not getting any activation details in my terminal besides I am always getting error in my terminal whenever I try npm I

@alexanmtz
Copy link
Member Author

alexanmtz commented Feb 21, 2024 via email

@Dheeraj4103
Copy link
Contributor

@alexanmtz Can you please assign me to this issue ?

@alexanmtz
Copy link
Member Author

Yes @Dheeraj4103 , feel free to send a PR with your solution 👌

@Dheeraj4103
Copy link
Contributor

Thanks @alexanmtz , I will start working on it.

@Dheeraj4103
Copy link
Contributor

Dheeraj4103 commented Aug 9, 2024

Hey @alexanmtz , there are lot of libraries that are deprecated, even if I use docker to build project both frontend and backend fails.

@alexanmtz
Copy link
Member Author

@Dheeraj4103 I guess we need to fix docker-compose to make it work properly:
#1010

And for run the project without docker and install with decrecated dependencies you need to run:
npm i --legacy-peer-deps

@Dheeraj4103
Copy link
Contributor

hey @alexanmtz, some packages require node v12 but some require version > v14, even after using command given by I'm not able to setup project

@alexanmtz
Copy link
Member Author

@Dheeraj4103 You need to use Node v17 to be able to run the backend server, and for the fron-end you can run the project with npm i --legacy-peer-deps

@Dheeraj4103
Copy link
Contributor

hey @alexanmtz I tried what you said but it didn't work.

@Dheeraj4103
Copy link
Contributor

You need to update package.json because many packages are deprecated and suggested to use alternative packages like
image

@alexanmtz
Copy link
Member Author

@Dheeraj4103, have you updated and made it work? If that's the case, you can send a PR with the fix

@alexanmtz
Copy link
Member Author

@Dheeraj4103 have you tried this? https://stackoverflow.com/questions/65594119/node-sass-usage-is-deprecated-and-will-be-removed-in-a-future-major-version

And just to make sure, your issue is on the Node server right?

@Dheeraj4103
Copy link
Contributor

Hey @alexanmtz I have updated package.json for backend and it is working fine now, Thanks for help.
Frontend is also working fine
But I have tried seeding the database but it doesn't work.
image

@alexanmtz
Copy link
Member Author

That's a great progress @Dheeraj4103, and it's really weird the seed having this output.

Have you ran the migrations successfully with npm run migrate? You need to run this one first

And what's your OS? Windows? Linux? Mac?

@Dheeraj4103
Copy link
Contributor

Dheeraj4103 commented Aug 16, 2024

Hey @alexanmtz,
I have ran the migrations and it was successful, but I encountered an issue while seeding data,
My OS is Windows

@alexanmtz
Copy link
Member Author

@Dheeraj4103 please check our README file for running the seed on Windows:
https://github.com/worknenjoy/gitpay?tab=readme-ov-file#for-windows-users

@Dheeraj4103
Copy link
Contributor

hey @alexanmtz I have set up project.
But some data is not seeded, I think I need to Setup the project again.

Should I create a seperate PR for updated package.json

@Dheeraj4103
Copy link
Contributor

Hey @alexanmtz,
I have successfully set up project, and everything is working fine, I was able to Signup and login.
image

But there are few test cases that are failing, which are related to Task
image

@Dheeraj4103
Copy link
Contributor

Hey @alexanmtz,
I have successfully converted class component to functional component in skill.js file.
Please have a look at the PR and let me know if there is any issue.

@alexanmtz
Copy link
Member Author

alexanmtz commented Aug 19, 2024

Hey @alexanmtz, I have successfully set up project, and everything is working fine, I was able to Signup and login. !

But there are few test cases that are failing, which are related to Task image

thats great @Dheeraj4103 , I guess the tests are failing because you need to run the migration for tests too, so have you tried npm run migrate-test?

@Dheeraj4103
Copy link
Contributor

Hey @alexanmtz, I have successfully set up project, and everything is working fine, I was able to Signup and login. !
But there are few test cases that are failing, which are related to Task image

thats great @Dheeraj4103 , I guess the tests are failing because you need to run the migration for tests too, so have you tried npm run migrate-test?
yes I have tried this but it's still failing.
And please have a look at the PR that I have created.

@alexanmtz
Copy link
Member Author

Yeah @Dheeraj4103 I will start to review your PR :)

@alexanmtz
Copy link
Member Author

Your PR was merged and already in production @Dheeraj4103 , thanks for the contribution, and feel free to start work in any other issue you're interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants