-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sidebar to fallback frontpage. #43
base: feature/homepage-fallback
Are you sure you want to change the base?
Add sidebar to fallback frontpage. #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the whole structur of the frontpage needs to be changed.
.*-main
and .*-sidebar
should not behave differently on events, fallback and meeting minutes.
&-sidebar { | ||
border: 1px solid #dae1e7; | ||
border-radius: .25rem; | ||
padding: 15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this with a call to config($spacing, 'default')
(for 20px padding).
<div class="frontpage-fallback-minutes"> | ||
<?php | ||
$minutes->the_post(); | ||
<div class="main-inner"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.main-inner
is the wrapper for the whole page content, this should not be repeated here.
&-sidebar { | ||
border: 1px solid #dae1e7; | ||
border-radius: .25rem; | ||
padding: 15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace this with a call to config($spacing, 'default')
(for 20px padding).
<?php | ||
$minutes->the_post(); | ||
<div class="main-inner"> | ||
<div class="frontpage-fallback-minutes-main"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have a wrapper with .frontpage-fallback-minutes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or replace .main-inner
with .frontpage-fallback-minutes
I think we have to add the changes proposed in #41 in this step as well. |
It might be best to take a step back and streamline the content so that the front page only has one wrapper instead of two and only the contents change if there is no meetup. |
This pull request adds a sidebar to the fallback frontpage template (and also the latest commits from the master branch).