Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make-php - Make output file content pretty #395

Open
1 task done
sovetski opened this issue Apr 9, 2024 · 4 comments
Open
1 task done

make-php - Make output file content pretty #395

sovetski opened this issue Apr 9, 2024 · 4 comments

Comments

@sovetski
Copy link

sovetski commented Apr 9, 2024

Feature Request

Describe your use case and the problem you are facing

When we do wp i18n make-php it creates PHP files containing one line, like minified PHP, but If we want to delete the old .po/.mo files to work with only PHP translations, working one line generated files is not practical

image

Describe the solution you'd like

Formatted output will look better

image

@swissspidy
Copy link
Member

We can add a pretty-print option like we have for make-json. Wanna help put a PR together? :)

@sovetski
Copy link
Author

sovetski commented Apr 9, 2024

We can add a pretty-print option like we have for make-json. Wanna help put a PR together? :)

Done: #396

Let me know if something is not OK 😊

@kkmuffme
Copy link

kkmuffme commented Nov 6, 2024

What exactly is the benefit of pretty-printing? Do you not use .po files anymore at all or why would tracking changes in the .l10n.php matter?

Just asking :-)

@sovetski
Copy link
Author

sovetski commented Nov 6, 2024

@kkmuffme yes exactly it is to not use .po files anymore, php files are more readable and easy to edit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants