Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps update process_regeneration() to reflect changes in WP 5.3 #113

Open
azaozz opened this issue Aug 16, 2019 · 1 comment
Open

Perhaps update process_regeneration() to reflect changes in WP 5.3 #113

azaozz opened this issue Aug 16, 2019 · 1 comment

Comments

@azaozz
Copy link

azaozz commented Aug 16, 2019

Just an FYI that from WP 5.3 there are couple of functions to find and generate missing image sub-sizes, and the image meta is saved after each sub-size is generated.

For back-compat wp_generate_attachment_metadata() still returns the whole image meta array after all sub-sizes have been created (if the server doesn't run out of resources), but is not the best way to generate only missing image sub-sizes. See https://core.trac.wordpress.org/ticket/40439 and https://core.trac.wordpress.org/changeset/45538 (testing and suggestions welcome).

@schlessera
Copy link
Member

Thanks for the heads-up, @azaozz !

Yes, that looks like it would make everything a bit more streamlined. However, it also means maintaining two separate execution paths for solving the same issue, which might have different results...

I'll have to spend some time looking into this to see how best to support this new functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants