From 8d75d2f913a78055d317d21fa7cd2ce4b479ad64 Mon Sep 17 00:00:00 2001 From: Bhargav Date: Sun, 12 May 2019 22:57:29 +0530 Subject: [PATCH] #156 Fix PHPCS errors/warnings --- inc/class-command.php | 3 ++- inc/class-formatter.php | 4 ++- inc/class-profiler.php | 56 +++++++++++++++++++++++++---------------- phpcs.xml.dist | 6 +++++ 4 files changed, 45 insertions(+), 24 deletions(-) diff --git a/inc/class-command.php b/inc/class-command.php index 6fbd6268..ec16fb9b 100644 --- a/inc/class-command.php +++ b/inc/class-command.php @@ -368,7 +368,8 @@ function() use ( $file ) { */ private static function profile_eval_ish( $assoc_args, $profile_callback, $order = 'ASC', $orderby = null ) { $hook = Utils\get_flag_value( $assoc_args, 'hook' ); - $type = $focus = false; + $focus = false; + $type = false; $fields = array(); if ( $hook ) { $type = 'hook'; diff --git a/inc/class-formatter.php b/inc/class-formatter.php index 77558b6f..7ab4b2fb 100644 --- a/inc/class-formatter.php +++ b/inc/class-formatter.php @@ -93,7 +93,9 @@ private function show_table( $order, $orderby, $items, $fields, $include_total ) usort( $items, function( $a, $b ) use ( $order, $orderby ) { - list( $first, $second ) = 'ASC' === $order ? array( $a, $b ) : array( $b, $a ); + + $orderby_array = 'ASC' === $order ? array( $a, $b ) : array( $b, $a ); + list( $first, $second ) = $orderby_array; if ( is_numeric( $first->$orderby ) && is_numeric( $second->$orderby ) ) { return $this->compare_float( $first->$orderby, $second->$orderby ); diff --git a/inc/class-profiler.php b/inc/class-profiler.php index fe8e43a1..529504c6 100644 --- a/inc/class-profiler.php +++ b/inc/class-profiler.php @@ -8,8 +8,8 @@ class Profiler { private $type; private $focus; - private $loggers = array(); - private $stage_hooks = array( + private $loggers = array(); + private $stage_hooks = array( 'bootstrap' => array( 'muplugins_loaded', 'plugins_loaded', @@ -34,6 +34,7 @@ class Profiler { 'wp_footer', ), ); + private $current_stage_hooks = array(); private $running_hook = null; private $previous_filter = null; @@ -55,7 +56,8 @@ public function __construct( $type, $focus ) { public function get_loggers() { foreach ( $this->loggers as $i => $logger ) { if ( is_array( $logger ) ) { - $this->loggers[ $i ] = $logger = new Logger( $logger ); + $logger = new Logger( $logger ); + $this->loggers[ $i ] = $logger; } if ( ! isset( $logger->callback ) ) { continue; @@ -78,7 +80,8 @@ public function run() { WP_CLI::add_wp_hook( 'muplugins_loaded', function() { - if ( $url = WP_CLI::get_runner()->config['url'] ) { + $url = WP_CLI::get_runner()->config['url']; + if ( ! empty( $url ) ) { WP_CLI::set_url( trailingslashit( $url ) ); } else { WP_CLI::set_url( home_url( '/' ) ); @@ -103,7 +106,7 @@ function() { $stage_hooks = array_merge( $stage_hooks, $hooks ); } $end_hook = substr( $this->focus, 0, -7 ); - $key = array_search( $end_hook, $stage_hooks ); + $key = array_search( $end_hook, $stage_hooks, true ); if ( isset( $stage_hooks[ $key - 1 ] ) ) { $start_hook = $stage_hooks[ $key - 1 ]; WP_CLI::add_wp_hook( $start_hook, array( $this, 'wp_tick_profile_begin' ), 9999 ); @@ -136,17 +139,22 @@ public function wp_tick_profile_begin( $value = null ) { // and hide calls from the tick handler and backtraces. // Copied from P3 Profiler if ( extension_loaded( 'xcache' ) ) { - @ini_set( 'xcache.optimizer', false ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. + @ini_set( 'xcache.optimizer', false ); // phpcs:ignore + // WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. } elseif ( extension_loaded( 'apc' ) ) { - @ini_set( 'apc.optimization', 0 ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. + @ini_set( 'apc.optimization', 0 ); // phpcs:ignore + // WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. apc_clear_cache(); } elseif ( extension_loaded( 'eaccelerator' ) ) { - @ini_set( 'eaccelerator.optimizer', 0 ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. + @ini_set( 'eaccelerator.optimizer', 0 ); // phpcs:ignore + // WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. if ( function_exists( 'eaccelerator_optimizer' ) ) { - @eaccelerator_optimizer( false ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged -- disabling eaccelerator on runtime can faild + @eaccelerator_optimizer( false ); // phpcs:ignore + // WordPress.PHP.NoSilencedErrors.Discouraged -- disabling eaccelerator on runtime can faild } } elseif ( extension_loaded( 'Zend Optimizer+' ) ) { - @ini_set( 'zend_optimizerplus.optimization_level', 0 ); // phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. + @ini_set( 'zend_optimizerplus.optimization_level', 0 ); // phpcs:ignore + // WordPress.PHP.NoSilencedErrors.Discouraged -- ini_set can be disabled on server. } register_tick_function( array( $this, 'handle_function_tick' ) ); @@ -173,7 +181,7 @@ public function wp_hook_begin() { } $current_filter = current_filter(); - if ( ( 'stage' === $this->type && in_array( $current_filter, $this->current_stage_hooks ) ) + if ( ( 'stage' === $this->type && in_array( $current_filter, $this->current_stage_hooks, true ) ) || ( 'hook' === $this->type && ! $this->focus ) ) { $pseudo_hook = "{$current_filter}:before"; if ( isset( $this->loggers[ $pseudo_hook ] ) ) { @@ -257,11 +265,11 @@ public function wp_hook_end( $filter_value = null ) { } $current_filter = current_filter(); - if ( ( 'stage' === $this->type && in_array( $current_filter, $this->current_stage_hooks ) ) + if ( ( 'stage' === $this->type && in_array( $current_filter, $this->current_stage_hooks, true ) ) || ( 'hook' === $this->type && ! $this->focus ) ) { $this->loggers[ $current_filter ]->stop(); if ( 'stage' === $this->type ) { - $key = array_search( $current_filter, $this->current_stage_hooks ); + $key = array_search( $current_filter, $this->current_stage_hooks, true ); if ( false !== $key && isset( $this->current_stage_hooks[ $key + 1 ] ) ) { $pseudo_hook = "{$this->current_stage_hooks[$key+1]}:before"; } else { @@ -287,7 +295,7 @@ public function handle_function_tick() { if ( ! is_null( $this->tick_callback ) ) { $time = microtime( true ) - $this->tick_start_time; - $callback_hash = md5( serialize( $this->tick_callback . $this->tick_location ) ); + $callback_hash = md5( serialize( $this->tick_callback . $this->tick_location ) ); // phpcs:ignore if ( ! isset( $this->loggers[ $callback_hash ] ) ) { $this->loggers[ $callback_hash ] = array( 'callback' => $this->tick_callback, @@ -304,7 +312,8 @@ public function handle_function_tick() { $this->loggers[ $callback_hash ]['time'] += $time; if ( isset( $wpdb ) ) { - for ( $i = $this->tick_query_offset; $i < count( $wpdb->queries ); $i++ ) { + $total_queries = count( $wpdb->queries ); + for ( $i = $this->tick_query_offset; $i < $total_queries; $i++ ) { $this->loggers[ $callback_hash ]['query_time'] += $wpdb->queries[ $i ][1]; $this->loggers[ $callback_hash ]['query_count']++; } @@ -329,8 +338,9 @@ public function handle_function_tick() { $frame = $bt[1]; } - $callback = $location = ''; - if ( in_array( strtolower( $frame['function'] ), array( 'include', 'require', 'include_once', 'require_once' ) ) ) { + $location = ''; + $callback = ''; + if ( in_array( strtolower( $frame['function'] ), array( 'include', 'require', 'include_once', 'require_once' ), true ) ) { $callback = $frame['function'] . " '" . $frame['args'][0] . "'"; } elseif ( isset( $frame['object'] ) && method_exists( $frame['object'], $frame['function'] ) ) { $callback = get_class( $frame['object'] ) . '->' . $frame['function'] . '()'; @@ -338,7 +348,7 @@ public function handle_function_tick() { $callback = $frame['class'] . '::' . $frame['function'] . '()'; } elseif ( ! empty( $frame['function'] ) && function_exists( $frame['function'] ) ) { $callback = $frame['function'] . '()'; - } elseif ( '__lambda_func' == $frame['function'] || '{closure}' == $frame['function'] ) { + } elseif ( '__lambda_func' === $frame['function'] || '{closure}' === $frame['function'] ) { $callback = 'function(){}'; } @@ -447,7 +457,8 @@ private function load_wordpress_with_template() { // Template is normally loaded in global scope, so we need to replicate foreach ( $GLOBALS as $key => $value ) { - global ${$key}; // phpcs:ignore PHPCompatibility.PHP.ForbiddenGlobalVariableVariable.NonBareVariableFound -- Syntax is updated to compatible with php 5 and 7. + global ${$key}; // phpcs:ignore + // PHPCompatibility.PHP.ForbiddenGlobalVariableVariable.NonBareVariableFound -- Syntax is updated to compatible with php 5 and 7. } // Load the theme template. @@ -480,7 +491,8 @@ private function load_wordpress_with_template() { * Get a human-readable name from a callback */ private static function get_name_location_from_callback( $callback ) { - $name = $location = ''; + $location = ''; + $name = ''; $reflection = false; if ( is_array( $callback ) && is_object( $callback[0] ) ) { $reflection = new \ReflectionMethod( $callback[0], $callback[1] ); @@ -567,13 +579,13 @@ private static function set_filter_callbacks( $filter, $callbacks ) { global $wp_filter; if ( ! isset( $wp_filter[ $filter ] ) && class_exists( 'WP_Hook' ) ) { - $wp_filter[ $filter ] = new \WP_Hook(); + $wp_filter[ $filter ] = new \WP_Hook(); // phpcs:ignore } if ( is_a( $wp_filter[ $filter ], 'WP_Hook' ) ) { $wp_filter[ $filter ]->callbacks = $callbacks; } else { - $wp_filter[ $filter ] = $callbacks; + $wp_filter[ $filter ] = $callbacks; // phpcs:ignore } } diff --git a/phpcs.xml.dist b/phpcs.xml.dist index 935ed949..e756128a 100644 --- a/phpcs.xml.dist +++ b/phpcs.xml.dist @@ -51,5 +51,11 @@ + */inc/*.php$ + + + */inc/class-profiler.php$ + +