Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WordPress exclusions to PHPCS compatibility sniffer #155

Closed
schlessera opened this issue Jun 4, 2018 · 1 comment
Closed

Add WordPress exclusions to PHPCS compatibility sniffer #155

schlessera opened this issue Jun 4, 2018 · 1 comment

Comments

@schlessera
Copy link
Member

We've added PHPCompatibility sniffing to the plugin scaffolding now via #154.

This only does the general checks for PHP compatibility. We should however use the WordPress-specific exclusion list instead, as described here: #60 (comment)

To do this, we would usually just link to the rule file in the Composer vendor folder. But most plugin developers will not know how to deal with Composer, so adding that is not an option right now.

We need to think about a way for referencing this ruleset in a global installation of the PHPCompatibility sniffer instead.

@jrfnl
Copy link
Contributor

jrfnl commented Aug 14, 2018

AFAICS this issue can be closed as the PHPCompatibility project now offers a WP specific ruleset and the PHPCS ruleset and the Composer config have been adjusted to use that ruleset in PR #161.

@schlessera schlessera added this to the 2.0.0 milestone Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants