Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab CI tests lacks tests for different WP versions #69

Open
nextgenthemes opened this issue Oct 15, 2017 · 3 comments
Open

Gitlab CI tests lacks tests for different WP versions #69

nextgenthemes opened this issue Oct 15, 2017 · 3 comments

Comments

@nextgenthemes
Copy link
Contributor

nextgenthemes commented Oct 15, 2017

Or am I missing something?

I am used to travis where you can define several WP versions for the tests.

I am new to docker but I have a fair knowlege about Linux and Ubuntu.

One way that could be done is by actually just cleaning the /tmp folder and installing the tests again with a different WP version. This way not a complete new docker bootup would be needed. Not sure if that is a good way.

Like this. Assuming the config that wp-cli currently adds. Untested

PHPunit:PHP5.3:MySQL:
  image: tetraweb/php:5.3
  services:
    - mysql:5.6
  script:
  - phpcs
  - phpunit
  - rm -rf /tmp/*
  - bash bin/install-wp-tests.sh wordpress_tests root mysql mysql nightly true
  - phpcs
  - phpunit
@schlessera
Copy link
Member

Related #25

@schlessera
Copy link
Member

Related #30

@danielbachhuber
Copy link
Member

One way that could be done is by actually just cleaning the /temp folder and installing the tests again with a different WP version. This way not a complete new docker bootup would be needed. Nut sure if that is a good way.

This is how we've done it with Circle 1.0 too.

No reason that it hasn't been done other than that it wasn't done. It'd be nice to get a sample repo going on GitLab so we can test these changes to the scaffolded configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants