Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for Xpath selectors #186

Open
theodesp opened this issue Feb 6, 2024 · 1 comment
Open

Feature: Add support for Xpath selectors #186

theodesp opened this issue Feb 6, 2024 · 1 comment
Labels
good first issue Issue that doesn't require previous experience with codebase scope: html parsing status: actionable Ready for work to begin type: feature New functionality being added

Comments

@theodesp
Copy link
Member

theodesp commented Feb 6, 2024

Description

Due to this #185 some selectors are wrong and do not capture accurately the html contents of an attribute. In that case we can replace those selectors with Xpath.

Acceptance criteria

  • XPath selectors are supported
  • Documentation entry added in Faust.org

Technical details

  • Do a simple check if the selector starts with either (// or // to determine if its an Xpath selector.
@theodesp theodesp added type: feature New functionality being added good first issue Issue that doesn't require previous experience with codebase labels Feb 6, 2024
@justlevine
Copy link
Contributor

Cross responding here from #185 (comment):

I havn't been following this issue too closely, but please keep in mind the general changes to the Block API as you're making these decisions.

Between the Interactivity API and Block Bindings API coming up, my gut tells me that we want to be using the HTML parser (assuming there isn't something block-specific to handle Lightbox Images, and to stay away from using Xpath directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issue that doesn't require previous experience with codebase scope: html parsing status: actionable Ready for work to begin type: feature New functionality being added
Projects
None yet
Development

No branches or pull requests

3 participants